Commit 6737201
test: move test that depends on dns query to internet
These test cases in `test/parallel/test-dns-lookup.js` send
dns requests and depend on the results, which could fail
if the DNS service for invalid hosts is hijacked by the ISP.
PR-URL: #22516
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 4862ce1 commit 6737201
2 files changed
Lines changed: 30 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1,30 @@ | |||
| 1 | + 'use strict'; | ||
| 2 | + | ||
| 3 | + require('../common'); | ||
| 4 | + const dnsPromises = require('dns').promises; | ||
| 5 | + const { addresses } = require('../common/internet'); | ||
| 6 | + const assert = require('assert'); | ||
| 7 | + | ||
| 8 | + assert.rejects( | ||
| 9 | + dnsPromises.lookup(addresses.INVALID_HOST, { | ||
| 10 | + hints: 0, | ||
| 11 | + family: 0, | ||
| 12 | + all: false | ||
| 13 | + }), | ||
| 14 | + { | ||
| 15 | + code: 'ENOTFOUND', | ||
| 16 | + message: `getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}` | ||
| 17 | + } | ||
| 18 | + ); | ||
| 19 | + | ||
| 20 | + assert.rejects( | ||
| 21 | + dnsPromises.lookup(addresses.INVALID_HOST, { | ||
| 22 | + hints: 0, | ||
| 23 | + family: 0, | ||
| 24 | + all: true | ||
| 25 | + }), | ||
| 26 | + { | ||
| 27 | + code: 'ENOTFOUND', | ||
| 28 | + message: `getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}` | ||
| 29 | + } | ||
| 30 | + ); | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,6 +1,5 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | 2 | const common = require('../common'); | |
| 3 | - const { addresses } = require('../common/internet'); | ||
| 4 | 3 | const assert = require('assert'); | |
| 5 | 4 | const cares = process.binding('cares_wrap'); | |
| 6 | 5 | const dns = require('dns'); | |
@@ -93,30 +92,6 @@ common.expectsError(() => { | |||
| 93 | 92 | all: false | |
| 94 | 93 | }); | |
| 95 | 94 | assert.deepStrictEqual(res, { address: '127.0.0.1', family: 4 }); | |
| 96 | - | ||
| 97 | - assert.rejects( | ||
| 98 | - dnsPromises.lookup(addresses.INVALID_HOST, { | ||
| 99 | - hints: 0, | ||
| 100 | - family: 0, | ||
| 101 | - all: false | ||
| 102 | - }), | ||
| 103 | - { | ||
| 104 | - code: 'ENOTFOUND', | ||
| 105 | - message: `getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}` | ||
| 106 | - } | ||
| 107 | - ); | ||
| 108 | - | ||
| 109 | - assert.rejects( | ||
| 110 | - dnsPromises.lookup(addresses.INVALID_HOST, { | ||
| 111 | - hints: 0, | ||
| 112 | - family: 0, | ||
| 113 | - all: true | ||
| 114 | - }), | ||
| 115 | - { | ||
| 116 | - code: 'ENOTFOUND', | ||
| 117 | - message: `getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}` | ||
| 118 | - } | ||
| 119 | - ); | ||
| 120 | 95 | })(); | |
| 121 | 96 | ||
| 122 | 97 | dns.lookup(false, { | |
0 commit comments