test: avoid using Object.prototype methods directly on objects · nodejs/node@673c1fd · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 673c1fd

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

danielleadams

committed

test: avoid using Object.prototype methods directly on objects

This prepares us to enable the no-prototype-builtins ESLint rule. Refs: https://eslint.org/docs/rules/no-prototype-builtins PR-URL: #41801 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>

1 parent 4660c1f commit 673c1fd
Copy full SHA for 673c1fd

2 files changed

+5-5Lines changed: 5 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-console-group.js
  • test-stream-base-prototype-accessors-enumerability.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-console-group.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-console-group.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -151,7 +151,7 @@ function teardown() {
151	151	// Check that the kGroupIndent symbol property is not enumerable
152	152	{
153	153	const keys = Reflect.ownKeys(console)
154		- .filter((val) => console.propertyIsEnumerable(val))
	154	+ .filter((val) => Object.prototype.propertyIsEnumerable.call(console, val))
155	155	.map((val) => val.toString());
156	156	assert(!keys.includes('Symbol(groupIndent)'),
157	157	'groupIndent should not be enumerable');

Collapse file

‎test/parallel/test-stream-base-prototype-accessors-enumerability.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-stream-base-prototype-accessors-enumerability.js

+4-4Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -14,8 +14,8 @@ const { internalBinding } = require('internal/test/binding');
14	14	const TTY = internalBinding('tty_wrap').TTY;
15	15
16	16	{
17		- assert.strictEqual(TTY.prototype.propertyIsEnumerable('bytesRead'), false);
18		- assert.strictEqual(TTY.prototype.propertyIsEnumerable('fd'), false);
19		- assert.strictEqual(
20		- TTY.prototype.propertyIsEnumerable('_externalStream'), false);
	17	+ const ttyIsEnumerable = Object.prototype.propertyIsEnumerable.bind(TTY);
	18	+ assert.strictEqual(ttyIsEnumerable('bytesRead'), false);
	19	+ assert.strictEqual(ttyIsEnumerable('fd'), false);
	20	+ assert.strictEqual(ttyIsEnumerable('_externalStream'), false);
21	21	}

0 commit comments

Comments

0 (0)