url: fix definitions of `URL`/`SearchParams` methods and accessors · nodejs/node@676f696 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 758
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 676f696

Browse filesBrowse the repository at this point in the historyBrowse files

ExE-Boss

authored and

danielleadams

committed

url: fix definitions of URL/SearchParams methods and accessors

This fixes getter and setter names for the WHATWG URL classes, and fixes a few other inconsistencies with browsers implementations. Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de> PR-URL: #36799 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

1 parent fbcab10 commit 676f696
Copy full SHA for 676f696

2 files changed

+404-316Lines changed: 404 additions & 316 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • url.js
• test/parallel
  • test-whatwg-url-properties.js

Expand file treeCollapse file tree

Open diff view settings

0 commit comments

Comments

0 (0)