Commit 6775958
File tree
- .github/workflows
- deps/v8/src/objects
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,7 +18,11 @@ env: | |||
| 18 | 18 | jobs: | |
| 19 | 19 | build-windows: | |
| 20 | 20 | if: github.event.pull_request.draft == false | |
| 21 | - runs-on: windows-latest | ||
| 21 | + strategy: | ||
| 22 | + matrix: | ||
| 23 | + windows: [windows-2019, windows-2022] | ||
| 24 | + fail-fast: false | ||
| 25 | + runs-on: ${{ matrix.windows }} | ||
| 22 | 26 | steps: | |
| 23 | 27 | - uses: actions/checkout@v2 | |
| 24 | 28 | - name: Set up Python ${{ env.PYTHON_VERSION }} | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.12', | ||
| 39 | + 'v8_embedder_string': '-node.13', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -84,7 +84,7 @@ bool FixedArray::is_the_hole(Isolate* isolate, int index) { | |||
| 84 | 84 | return get(isolate, index).IsTheHole(isolate); | |
| 85 | 85 | } | |
| 86 | 86 | ||
| 87 | - #if !defined(_WIN32) || defined(_WIN64) | ||
| 87 | + #if !defined(_WIN32) || (defined(_WIN64) && _MSC_VER < 1930) | ||
| 88 | 88 | void FixedArray::set(int index, Smi value) { | |
| 89 | 89 | DCHECK_NE(map(), GetReadOnlyRoots().fixed_cow_array_map()); | |
| 90 | 90 | DCHECK_LT(static_cast<unsigned>(index), static_cast<unsigned>(length())); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -134,16 +134,16 @@ class FixedArray | |||
| 134 | 134 | inline bool is_the_hole(Isolate* isolate, int index); | |
| 135 | 135 | ||
| 136 | 136 | // Setter that doesn't need write barrier. | |
| 137 | - #if defined(_WIN32) && !defined(_WIN64) | ||
| 137 | + #if !defined(_WIN32) || (defined(_WIN64) && _MSC_VER < 1930) | ||
| 138 | + inline void set(int index, Smi value); | ||
| 139 | + #else | ||
| 138 | 140 | inline void set(int index, Smi value) { | |
| 139 | 141 | DCHECK_NE(map(), GetReadOnlyRoots().fixed_cow_array_map()); | |
| 140 | 142 | DCHECK_LT(static_cast<unsigned>(index), static_cast<unsigned>(length())); | |
| 141 | 143 | DCHECK(Object(value).IsSmi()); | |
| 142 | 144 | int offset = OffsetOfElementAt(index); | |
| 143 | 145 | RELAXED_WRITE_FIELD(*this, offset, value); | |
| 144 | 146 | } | |
| 145 | - #else | ||
| 146 | - inline void set(int index, Smi value); | ||
| 147 | 147 | #endif | |
| 148 | 148 | ||
| 149 | 149 | // Setter with explicit barrier mode. | |
0 commit comments