Commit 67812e8
tools: re-implement lint-md without unified-args
`unified-args` ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes `unified-args`. This means the preset settings are
now respected and it removes nearly 30000 lines of code in the resulting
rollup file.
I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
`node_modules`.
PR-URL: #40180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 6489423 commit 67812e8
15 files changed
Lines changed: 22658 additions & 51162 deletions
File tree
- .github/workflows
- tools
- lint-md
- node-lint-md-cli-rollup
- src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,8 +4,7 @@ test/addons/??_* | |||
| 4 | 4 | test/fixtures | |
| 5 | 5 | test/message/esm_display_syntax_error.mjs | |
| 6 | 6 | tools/icu | |
| 7 | - tools/lint-md.mjs | ||
| 8 | - tools/node-lint-md-cli-rollup/dist | ||
| 7 | + tools/lint-md/lint-md.mjs | ||
| 9 | 8 | benchmark/tmp | |
| 10 | 9 | doc/**/*.js | |
| 11 | 10 | !.eslintrc.js | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -55,7 +55,7 @@ jobs: | |||
| 55 | 55 | - name: Get release version numbers | |
| 56 | 56 | if: ${{ github.event.pull_request && github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch }} | |
| 57 | 57 | id: get-released-versions | |
| 58 | - run: ./tools/node-lint-md-cli-rollup/src/list-released-versions-from-changelogs.mjs | ||
| 58 | + run: ./tools/lint-md/list-released-versions-from-changelogs.mjs | ||
| 59 | 59 | - name: Lint docs | |
| 60 | 60 | run: | | |
| 61 | 61 | echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json" | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1221,12 +1221,11 @@ bench-addons-clean: | |||
| 1221 | 1221 | .PHONY: lint-md-rollup | |
| 1222 | 1222 | lint-md-rollup: | |
| 1223 | 1223 | $(RM) tools/.*mdlintstamp | |
| 1224 | - cd tools/node-lint-md-cli-rollup && npm install | ||
| 1225 | - cd tools/node-lint-md-cli-rollup && npm run build-node | ||
| 1224 | + cd tools/lint-md && npm ci && npm run build | ||
| 1226 | 1225 | ||
| 1227 | 1226 | .PHONY: lint-md-clean | |
| 1228 | 1227 | lint-md-clean: | |
| 1229 | - $(RM) -r tools/node-lint-md-cli-rollup/node_modules | ||
| 1228 | + $(RM) -r tools/lint-md/node_modules | ||
| 1230 | 1229 | $(RM) tools/.*mdlintstamp | |
| 1231 | 1230 | ||
| 1232 | 1231 | .PHONY: lint-md-build | |
@@ -1243,7 +1242,7 @@ LINT_MD_TARGETS = doc src lib benchmark test tools/doc tools/icu $(wildcard *.md | |||
| 1243 | 1242 | LINT_MD_FILES = $(shell $(FIND) $(LINT_MD_TARGETS) -type f \ | |
| 1244 | 1243 | ! -path '*node_modules*' ! -path 'test/fixtures/*' -name '*.md' \ | |
| 1245 | 1244 | $(LINT_MD_NEWER)) | |
| 1246 | - run-lint-md = tools/lint-md.mjs -q -f --no-stdout $(LINT_MD_FILES) | ||
| 1245 | + run-lint-md = tools/lint-md/lint-md.mjs $(LINT_MD_FILES) | ||
| 1247 | 1246 | # Lint all changed markdown files maintained by us | |
| 1248 | 1247 | tools/.mdlintstamp: $(LINT_MD_FILES) | |
| 1249 | 1248 | $(info Running Markdown linter...) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -0,0 +1 @@ | |||
| 1 | + node_modules | ||
0 commit comments