crypto: fix webcrypto generateKey() with empty usages · nodejs/node@679f191 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 679f191

Browse filesBrowse the repository at this point in the historyBrowse files

panva

authored and

targos

committed

crypto: fix webcrypto generateKey() with empty usages

PR-URL: #43431 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent 64a9dd7 commit 679f191
Copy full SHA for 679f191

3 files changed

+15-1Lines changed: 15 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/crypto
  • webcrypto.js
• test/parallel
  • test-webcrypto-keygen.js
  • test-webcrypto-sign-verify-hmac.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/crypto/webcrypto.js‎

Copy file name to clipboardExpand all lines: lib/internal/crypto/webcrypto.js

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -89,6 +89,11 @@ async function generateKey(
89	89	algorithm = normalizeAlgorithm(algorithm);
90	90	validateBoolean(extractable, 'extractable');
91	91	validateArray(keyUsages, 'keyUsages');
	92	+ if (keyUsages.length === 0) {
	93	+ throw lazyDOMException(
	94	+ 'Usages cannot be empty when creating a key',
	95	+ 'SyntaxError');
	96	+ }
92	97	switch (algorithm.name) {
93	98	case 'RSASSA-PKCS1-v1_5':
94	99	// Fall through

Collapse file

‎test/parallel/test-webcrypto-keygen.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-webcrypto-keygen.js

+9Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -210,6 +210,15 @@ const vectors = {
210	210	// Test bad usages
211	211	{
212	212	async function test(name) {
	213	+ await assert.rejects(
	214	+ subtle.generateKey(
	215	+ {
	216	+ name, ...vectors[name].algorithm
	217	+ },
	218	+ true,
	219	+ []),
	220	+ { message: /Usages cannot be empty/ });
	221	+
213	222	const invalidUsages = [];
214	223	allUsages.forEach((usage) => {
215	224	if (!vectors[name].usages.includes(usage))

Collapse file

‎test/parallel/test-webcrypto-sign-verify-hmac.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-webcrypto-sign-verify-hmac.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -153,7 +153,7 @@ async function testSign({ hash,
153	153	}
154	154
155	155	await assert.rejects(
156		- subtle.generateKey({ name }, false, []), {
	156	+ subtle.generateKey({ name }, false, ['sign', 'verify']), {
157	157	name: 'TypeError',
158	158	code: 'ERR_MISSING_OPTION',
159	159	message: 'algorithm.hash is required'

0 commit comments

Comments

0 (0)