Commit 67b2c2a
doc: fix broken link to new folder doc/contributing/maintaining
PR-URL: #48205
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent 795ca70 commit 67b2c2a
4 files changed
Lines changed: 6 additions & 5 deletions
File tree
- .github/workflows
- deps/openssl
- tools/dep_updaters
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -48,7 +48,7 @@ jobs: | |||
| 48 | 48 | body: | | |
| 49 | 49 | This PR was generated by tools/timezone-update.yml. | |
| 50 | 50 | ||
| 51 | - Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data | ||
| 51 | + Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-icu.md#time-zone-data | ||
| 52 | 52 | ||
| 53 | 53 | To test, build node off this branch & log the version of tz using | |
| 54 | 54 | ```js | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -86,4 +86,4 @@ Also remove the architecture from the list of supported ASM architectures in | |||
| 86 | 86 | ||
| 87 | 87 | ### Upgrading OpenSSL | |
| 88 | 88 | ||
| 89 | - Please refer to [maintaining-openssl](../../doc/contributing/maintaining-openssl.md). | ||
| 89 | + Please refer to [maintaining-openssl](../../doc/contributing/maintaining/maintaining-openssl.md). | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,7 +1,7 @@ | |||
| 1 | 1 | #!/bin/sh | |
| 2 | 2 | set -e | |
| 3 | 3 | # Shell script to update OpenSSL in the source tree to a specific version | |
| 4 | - # Based on https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-openssl.md | ||
| 4 | + # Based on https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-openssl.md | ||
| 5 | 5 | ||
| 6 | 6 | cleanup() { | |
| 7 | 7 | EXIT_CODE=$? | |
@@ -56,7 +56,7 @@ regenerate() { | |||
| 56 | 56 | ||
| 57 | 57 | make -C "$DEPS_DIR/openssl/config" clean | |
| 58 | 58 | # Needed for compatibility with nasm on 32-bit Windows | |
| 59 | - # See https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-openssl.md#2-execute-make-in-depsopensslconfig-directory | ||
| 59 | + # See https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-openssl.md#2-execute-make-in-depsopensslconfig-directory | ||
| 60 | 60 | sed -i 's/#ifdef/%ifdef/g' "$DEPS_DIR/openssl/openssl/crypto/perlasm/x86asm.pl" | |
| 61 | 61 | sed -i 's/#endif/%endif/g' "$DEPS_DIR/openssl/openssl/crypto/perlasm/x86asm.pl" | |
| 62 | 62 | make -C "$DEPS_DIR/openssl/config" | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,7 +3,8 @@ | |||
| 3 | 3 | # This function logs the archive checksum and, if provided, compares it with | |
| 4 | 4 | # the deposited checksum | |
| 5 | 5 | # | |
| 6 | - # $1 is the package name e.g. 'acorn', 'ada', 'base64' etc. See that file | ||
| 6 | + # $1 is the package name e.g. 'acorn', 'ada', 'base64' etc. See the file | ||
| 7 | + # https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md | ||
| 7 | 8 | # for a complete list of package name | |
| 8 | 9 | # $2 is the downloaded archive | |
| 9 | 10 | # $3 (optional) is the deposited sha256 cheksum. When provided, it is checked | |
0 commit comments