tools: validate all commits that are pushed to `main` · nodejs/node@67c6975 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 67c6975

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

committed

tools: validate all commits that are pushed to main

PR-URL: #62246 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent d3fd4a9 commit 67c6975
Copy full SHA for 67c6975

1 file changed

+4-8Lines changed: 4 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • notify-on-push.yml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/notify-on-push.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/notify-on-push.yml

+4-8Lines changed: 4 additions & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -30,20 +30,16 @@ jobs:
30	30
31	31	validateCommitMessage:
32	32	name: Notify on Push on `main` with invalid message
33		- if: github.repository == 'nodejs/node'
34	33	# cannot use ubuntu-slim here because rtCamp/action-slack-notify is dockerized
35	34	runs-on: ubuntu-24.04-arm
36	35	steps:
37		- - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
38		- with:
39		- persist-credentials: false
40		- - name: Check commit message
	36	+ - name: Validate commits
	37	+ run: echo "$COMMITS" | npx -q core-validate-commit -
41	38	id: commit-check
42		- run: npx -q core-validate-commit "$COMMIT"
43	39	env:
44		- COMMIT: ${{ github.event.after }}
	40	+ COMMITS: ${{ toJSON(github.event.commits) }}
45	41	- name: Slack Notification
46		- if: ${{ failure() && steps.commit-check.conclusion == 'failure' }}
	42	+ if: ${{ failure() && steps.commit-check.conclusion == 'failure' && github.repository == 'nodejs/node' }}
47	43	uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # 2.3.3
48	44	env:
49	45	SLACK_COLOR: '#DE512A'

0 commit comments

Comments

0 (0)