Commit 67d97bc
test: improve test-assert
Add RegExp to check assert throws the expected AssertionErrors.
For the one with multiple flags is ok to hardcode the flags since the
spec indicates the ordering will always be `gim`:
Refs: http://www.ecma-international.org/ecma-262/6.0/#sec-get-regexp.prototype.flags
PR-URL: #10916
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 69a04a9 commit 67d97bc
1 file changed
Lines changed: 20 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -214,11 +214,26 @@ assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/g, /a/g)); | |||
| 214 | 214 | assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/i, /a/i)); | |
| 215 | 215 | assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/m, /a/m)); | |
| 216 | 216 | assert.doesNotThrow(makeBlock(a.deepStrictEqual, /a/igm, /a/igm)); | |
| 217 | - assert.throws(makeBlock(a.deepStrictEqual, /ab/, /a/)); | ||
| 218 | - assert.throws(makeBlock(a.deepStrictEqual, /a/g, /a/)); | ||
| 219 | - assert.throws(makeBlock(a.deepStrictEqual, /a/i, /a/)); | ||
| 220 | - assert.throws(makeBlock(a.deepStrictEqual, /a/m, /a/)); | ||
| 221 | - assert.throws(makeBlock(a.deepStrictEqual, /a/igm, /a/im)); | ||
| 217 | + assert.throws( | ||
| 218 | + makeBlock(a.deepStrictEqual, /ab/, /a/), | ||
| 219 | + /^AssertionError: \/ab\/ deepStrictEqual \/a\/$/ | ||
| 220 | + ); | ||
| 221 | + assert.throws( | ||
| 222 | + makeBlock(a.deepStrictEqual, /a/g, /a/), | ||
| 223 | + /^AssertionError: \/a\/g deepStrictEqual \/a\/$/ | ||
| 224 | + ); | ||
| 225 | + assert.throws( | ||
| 226 | + makeBlock(a.deepStrictEqual, /a/i, /a/), | ||
| 227 | + /^AssertionError: \/a\/i deepStrictEqual \/a\/$/ | ||
| 228 | + ); | ||
| 229 | + assert.throws( | ||
| 230 | + makeBlock(a.deepStrictEqual, /a/m, /a/), | ||
| 231 | + /^AssertionError: \/a\/m deepStrictEqual \/a\/$/ | ||
| 232 | + ); | ||
| 233 | + assert.throws( | ||
| 234 | + makeBlock(a.deepStrictEqual, /a/igm, /a/im), | ||
| 235 | + /^AssertionError: \/a\/gim deepStrictEqual \/a\/im$/ | ||
| 236 | + ); | ||
| 222 | 237 | ||
| 223 | 238 | { | |
| 224 | 239 | const re1 = /a/; | |
0 commit comments