Commit 67dba57
src: use ARES_SUCCESS instead of 0
Since error messages are also using defined values, it is more clear
to use the defined value even when the operation succeeds.
PR-URL: #48834
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>1 parent 4d70a2c commit 67dba57
1 file changed
Lines changed: 13 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1052,7 +1052,7 @@ int AnyTraits::Parse( | |||
| 1052 | 1052 | return status; | |
| 1053 | 1053 | ||
| 1054 | 1054 | wrap->CallOnComplete(ret); | |
| 1055 | - return 0; | ||
| 1055 | + return ARES_SUCCESS; | ||
| 1056 | 1056 | } | |
| 1057 | 1057 | ||
| 1058 | 1058 | int ATraits::Parse( | |
@@ -1086,7 +1086,7 @@ int ATraits::Parse( | |||
| 1086 | 1086 | Local<Array> ttls = AddrTTLToArray<ares_addrttl>(env, addrttls, naddrttls); | |
| 1087 | 1087 | ||
| 1088 | 1088 | wrap->CallOnComplete(ret, ttls); | |
| 1089 | - return 0; | ||
| 1089 | + return ARES_SUCCESS; | ||
| 1090 | 1090 | } | |
| 1091 | 1091 | ||
| 1092 | 1092 | int AaaaTraits::Parse( | |
@@ -1120,7 +1120,7 @@ int AaaaTraits::Parse( | |||
| 1120 | 1120 | Local<Array> ttls = AddrTTLToArray<ares_addr6ttl>(env, addrttls, naddrttls); | |
| 1121 | 1121 | ||
| 1122 | 1122 | wrap->CallOnComplete(ret, ttls); | |
| 1123 | - return 0; | ||
| 1123 | + return ARES_SUCCESS; | ||
| 1124 | 1124 | } | |
| 1125 | 1125 | ||
| 1126 | 1126 | int CaaTraits::Parse( | |
@@ -1142,7 +1142,7 @@ int CaaTraits::Parse( | |||
| 1142 | 1142 | return status; | |
| 1143 | 1143 | ||
| 1144 | 1144 | wrap->CallOnComplete(ret); | |
| 1145 | - return 0; | ||
| 1145 | + return ARES_SUCCESS; | ||
| 1146 | 1146 | } | |
| 1147 | 1147 | ||
| 1148 | 1148 | int CnameTraits::Parse( | |
@@ -1165,7 +1165,7 @@ int CnameTraits::Parse( | |||
| 1165 | 1165 | return status; | |
| 1166 | 1166 | ||
| 1167 | 1167 | wrap->CallOnComplete(ret); | |
| 1168 | - return 0; | ||
| 1168 | + return ARES_SUCCESS; | ||
| 1169 | 1169 | } | |
| 1170 | 1170 | ||
| 1171 | 1171 | int MxTraits::Parse( | |
@@ -1188,7 +1188,7 @@ int MxTraits::Parse( | |||
| 1188 | 1188 | return status; | |
| 1189 | 1189 | ||
| 1190 | 1190 | wrap->CallOnComplete(mx_records); | |
| 1191 | - return 0; | ||
| 1191 | + return ARES_SUCCESS; | ||
| 1192 | 1192 | } | |
| 1193 | 1193 | ||
| 1194 | 1194 | int NsTraits::Parse( | |
@@ -1211,7 +1211,7 @@ int NsTraits::Parse( | |||
| 1211 | 1211 | return status; | |
| 1212 | 1212 | ||
| 1213 | 1213 | wrap->CallOnComplete(names); | |
| 1214 | - return 0; | ||
| 1214 | + return ARES_SUCCESS; | ||
| 1215 | 1215 | } | |
| 1216 | 1216 | ||
| 1217 | 1217 | int TxtTraits::Parse( | |
@@ -1233,7 +1233,7 @@ int TxtTraits::Parse( | |||
| 1233 | 1233 | return status; | |
| 1234 | 1234 | ||
| 1235 | 1235 | wrap->CallOnComplete(txt_records); | |
| 1236 | - return 0; | ||
| 1236 | + return ARES_SUCCESS; | ||
| 1237 | 1237 | } | |
| 1238 | 1238 | ||
| 1239 | 1239 | int SrvTraits::Parse( | |
@@ -1255,7 +1255,7 @@ int SrvTraits::Parse( | |||
| 1255 | 1255 | return status; | |
| 1256 | 1256 | ||
| 1257 | 1257 | wrap->CallOnComplete(srv_records); | |
| 1258 | - return 0; | ||
| 1258 | + return ARES_SUCCESS; | ||
| 1259 | 1259 | } | |
| 1260 | 1260 | ||
| 1261 | 1261 | int PtrTraits::Parse( | |
@@ -1279,7 +1279,7 @@ int PtrTraits::Parse( | |||
| 1279 | 1279 | return status; | |
| 1280 | 1280 | ||
| 1281 | 1281 | wrap->CallOnComplete(aliases); | |
| 1282 | - return 0; | ||
| 1282 | + return ARES_SUCCESS; | ||
| 1283 | 1283 | } | |
| 1284 | 1284 | ||
| 1285 | 1285 | int NaptrTraits::Parse( | |
@@ -1301,7 +1301,7 @@ int NaptrTraits::Parse( | |||
| 1301 | 1301 | return status; | |
| 1302 | 1302 | ||
| 1303 | 1303 | wrap->CallOnComplete(naptr_records); | |
| 1304 | - return 0; | ||
| 1304 | + return ARES_SUCCESS; | ||
| 1305 | 1305 | } | |
| 1306 | 1306 | ||
| 1307 | 1307 | int SoaTraits::Parse( | |
@@ -1352,7 +1352,7 @@ int SoaTraits::Parse( | |||
| 1352 | 1352 | ares_free_data(soa_out); | |
| 1353 | 1353 | ||
| 1354 | 1354 | wrap->CallOnComplete(soa_record); | |
| 1355 | - return 0; | ||
| 1355 | + return ARES_SUCCESS; | ||
| 1356 | 1356 | } | |
| 1357 | 1357 | ||
| 1358 | 1358 | int ReverseTraits::Send(GetHostByAddrWrap* wrap, const char* name) { | |
@@ -1396,7 +1396,7 @@ int ReverseTraits::Parse( | |||
| 1396 | 1396 | HandleScope handle_scope(env->isolate()); | |
| 1397 | 1397 | Context::Scope context_scope(env->context()); | |
| 1398 | 1398 | wrap->CallOnComplete(HostentToNames(env, host)); | |
| 1399 | - return 0; | ||
| 1399 | + return ARES_SUCCESS; | ||
| 1400 | 1400 | } | |
| 1401 | 1401 | ||
| 1402 | 1402 | namespace { | |
0 commit comments