Commit 6809c2b
test: fix flaky child-process-fork-regr-gh-2847
Windows would die with ECONNRESET most times when running
this particular test. This commit makes handling these errors
more tolerable.
PR-URL: #4442
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 393e569 commit 6809c2b
2 files changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,7 +7,6 @@ prefix parallel | |||
| 7 | 7 | [true] # This section applies to all platforms | |
| 8 | 8 | ||
| 9 | 9 | [$system==win32] | |
| 10 | - test-child-process-fork-regr-gh-2847 : PASS,FLAKY | ||
| 11 | 10 | test-cluster-net-send : PASS,FLAKY | |
| 12 | 11 | test-cluster-shared-leak : PASS,FLAKY | |
| 13 | 12 | test-debug-no-context : PASS,FLAKY | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -18,6 +18,13 @@ if (!cluster.isMaster) { | |||
| 18 | 18 | } | |
| 19 | 19 | ||
| 20 | 20 | var server = net.createServer(function(s) { | |
| 21 | + if (common.isWindows) { | ||
| 22 | + s.on('error', function(err) { | ||
| 23 | + // Prevent possible ECONNRESET errors from popping up | ||
| 24 | + if (err.code !== 'ECONNRESET' || sendcount === 0) | ||
| 25 | + throw err; | ||
| 26 | + }); | ||
| 27 | + } | ||
| 21 | 28 | setTimeout(function() { | |
| 22 | 29 | s.destroy(); | |
| 23 | 30 | }, 100); | |
0 commit comments