Commit 68548dc
doc: fix inconsistencies in WeakSet and WeakMap comparison details
PR-URL: #56683
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 337cfb2 commit 68548dc
1 file changed
Lines changed: 8 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -904,11 +904,12 @@ weakSet2.add(obj); | |||
| 904 | 904 | ||
| 905 | 905 | // Comparing different instances fails, even with same contents | |
| 906 | 906 | assert.deepStrictEqual(weakSet1, weakSet2); | |
| 907 | - // AssertionError: Expected inputs to be strictly deep-equal: | ||
| 907 | + // AssertionError: Values have same structure but are not reference-equal: | ||
| 908 | 908 | // + actual - expected | |
| 909 | 909 | // | |
| 910 | - // + WeakSet { <items unknown> } | ||
| 911 | - // - WeakSet { <items unknown> } | ||
| 910 | + // WeakSet { | ||
| 911 | + // <items unknown> | ||
| 912 | + // } | ||
| 912 | 913 | ||
| 913 | 914 | // Comparing the same instance to itself succeeds | |
| 914 | 915 | assert.deepStrictEqual(weakSet1, weakSet1); | |
@@ -1013,11 +1014,12 @@ weakSet2.add(obj); | |||
| 1013 | 1014 | ||
| 1014 | 1015 | // Comparing different instances fails, even with same contents | |
| 1015 | 1016 | assert.deepStrictEqual(weakSet1, weakSet2); | |
| 1016 | - // AssertionError: Expected inputs to be strictly deep-equal: | ||
| 1017 | + // AssertionError: Values have same structure but are not reference-equal: | ||
| 1017 | 1018 | // + actual - expected | |
| 1018 | 1019 | // | |
| 1019 | - // + WeakSet { <items unknown> } | ||
| 1020 | - // - WeakSet { <items unknown> } | ||
| 1020 | + // WeakSet { | ||
| 1021 | + // <items unknown> | ||
| 1022 | + // } | ||
| 1021 | 1023 | ||
| 1022 | 1024 | // Comparing the same instance to itself succeeds | |
| 1023 | 1025 | assert.deepStrictEqual(weakSet1, weakSet1); | |
0 commit comments