test: fix `test-process-load-env-file` when path contains `'` · nodejs/node@68891a6 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 68891a6

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

targos

committed

test: fix test-process-load-env-file when path contains '

If the repo is cloned on a path that contains a quote, the test should not fail. PR-URL: #54511 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 4f82673 commit 68891a6
Copy full SHA for 68891a6

1 file changed

+6-2Lines changed: 6 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-process-load-env-file.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-process-load-env-file.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-process-load-env-file.js

+6-2Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -8,7 +8,7 @@ const { join } = require('node:path');
8	8
9	9	const basicValidEnvFilePath = fixtures.path('dotenv/basic-valid.env');
10	10	const validEnvFilePath = fixtures.path('dotenv/valid.env');
11		- const missingEnvFile = fixtures.path('dotenv/non-existent-file.env');
	11	+ const missingEnvFile = fixtures.path('dir%20with unusual"chars \'åß∂ƒ©∆¬…`/non-existent-file.env');
12	12
13	13	describe('process.loadEnvFile()', () => {
14	14
@@ -85,7 +85,11 @@ describe('process.loadEnvFile()', () => {
85	85	assert.match(child.stderr, /code: 'ERR_ACCESS_DENIED'/);
86	86	assert.match(child.stderr, /permission: 'FileSystemRead'/);
87	87	if (!common.isWindows) {
88		- assert(child.stderr.includes(`resource: '${JSON.stringify(missingEnvFile).replaceAll('"', '')}'`));
	88	+ const resource = /^\s+resource: (['"])(.+)\1$/m.exec(child.stderr);
	89	+ assert(resource);
	90	+ assert.strictEqual(resource[2], resource[1] === "'" ?
	91	+ missingEnvFile.replaceAll("'", "\\'") :
	92	+ JSON.stringify(missingEnvFile).slice(1, -1));
89	93	}
90	94	assert.strictEqual(child.code, 1);
91	95	});

0 commit comments

Comments

0 (0)