Commit 699cfa1
doc: fix macosx-firewall suggestion BUILDING
Adding back the changes made by commit# 791d560, that suggests running
macosx-firewall.sh script after bulid step. These changes were deleted
by commit# fc102d0, but they are still applicable.
PR-URL: #15829
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>1 parent ad69a65 commit 699cfa1
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -91,7 +91,7 @@ On macOS you will need to install the `Xcode Command Line Tools` by running | |||
| 91 | 91 | installed, you can find them under the menu `Xcode -> Open Developer Tool -> | |
| 92 | 92 | More Developer Tools...`. This step will install `clang`, `clang++`, and | |
| 93 | 93 | `make`. | |
| 94 | - * You may want to setup [firewall rules](tools/macosx-firewall.sh) | ||
| 94 | + * After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) | ||
| 95 | 95 | to avoid popups asking to accept incoming network connections when running tests: | |
| 96 | 96 | ||
| 97 | 97 | If the path to your build directory contains a space, the build will likely fail. | |
0 commit comments