Commit 6a01918
deps: cherry-pick 0353a1e from upstream V8
Original commit message:
Avoid disassembling Interpreted Regexp code
I found that v8 will crash when --print-code is turned on while Regexp
is interpreted. It crashes when trying to print Relocation info during
Disassembly. It should probably avoid printing out disassembly when the
Code object is a bytecode regexp.
Bug:
Change-Id: I35b531cb03996a303248652871452266c78fee38
Reviewed-on: https://chromium-review.googlesource.com/642127
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#47718}
PR-URL: #15599
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 25fd85d commit 6a01918
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1115,7 +1115,7 @@ RegExpEngine::CompilationResult RegExpCompiler::Assemble( | |||
| 1115 | 1115 | Handle<HeapObject> code = macro_assembler_->GetCode(pattern); | |
| 1116 | 1116 | isolate->IncreaseTotalRegexpCodeGenerated(code->Size()); | |
| 1117 | 1117 | work_list_ = NULL; | |
| 1118 | - #ifdef ENABLE_DISASSEMBLER | ||
| 1118 | + #if defined(ENABLE_DISASSEMBLER) && !defined(V8_INTERPRETED_REGEXP) | ||
| 1119 | 1119 | if (FLAG_print_code) { | |
| 1120 | 1120 | CodeTracer::Scope trace_scope(isolate->GetCodeTracer()); | |
| 1121 | 1121 | OFStream os(trace_scope.file()); | |
0 commit comments