Commit 6a33399
deps: backport detailed line info for CPU profiler
[cpu-profiler] Add flag to always generate accurate line info.
https://chromium.googlesource.com/v8/v8/+/
56baf56790de439b3f69e887e94beb3b301ed77c
[cpu-profiler] Turn on detailed line info for optimized code
https://chromium.googlesource.com/v8/v8/+/
84894ce6d2af7feb9e1f5574409355120887326c
[cpu-profiler] Separate the flags for generating extra line information
https://chromium.googlesource.com/v8/v8/+/
30ff6719db441cc7ef220d449970cc169067e256
PR-URL: #22688
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 688d01c commit 6a33399
5 files changed
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -29,7 +29,7 @@ | |||
| 29 | 29 | ||
| 30 | 30 | # Reset this number to 0 on major V8 upgrades. | |
| 31 | 31 | # Increment by one for each non-official patch applied to deps/v8. | |
| 32 | - 'v8_embedder_string': '-node.24', | ||
| 32 | + 'v8_embedder_string': '-node.25', | ||
| 33 | 33 | ||
| 34 | 34 | # Enable disassembler for `--print-code` v8 options | |
| 35 | 35 | 'v8_enable_disassembler': 1, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1211,6 +1211,9 @@ DEFINE_BOOL(log_function_events, false, | |||
| 1211 | 1211 | DEFINE_BOOL(prof, false, | |
| 1212 | 1212 | "Log statistical profiling information (implies --log-code).") | |
| 1213 | 1213 | ||
| 1214 | + DEFINE_BOOL(detailed_line_info, true, | ||
| 1215 | + "Always generate detailed line information for CPU profiling.") | ||
| 1216 | + | ||
| 1214 | 1217 | #if defined(ANDROID) | |
| 1215 | 1218 | // Phones and tablets have processors that are much slower than desktop | |
| 1216 | 1219 | // and laptop computers for which current heuristics are tuned. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3285,6 +3285,10 @@ bool Isolate::use_optimizer() { | |||
| 3285 | 3285 | !is_precise_count_code_coverage() && !is_block_count_code_coverage(); | |
| 3286 | 3286 | } | |
| 3287 | 3287 | ||
| 3288 | + bool Isolate::NeedsDetailedOptimizedCodeLineInfo() const { | ||
| 3289 | + return NeedsSourcePositionsForProfiling() || FLAG_detailed_line_info; | ||
| 3290 | + } | ||
| 3291 | + | ||
| 3288 | 3292 | bool Isolate::NeedsSourcePositionsForProfiling() const { | |
| 3289 | 3293 | return FLAG_trace_deopt || FLAG_trace_turbo || FLAG_trace_turbo_graph || | |
| 3290 | 3294 | FLAG_turbo_profiling || FLAG_perf_prof || is_profiling() || | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1022,6 +1022,8 @@ class Isolate : private HiddenFactory { | |||
| 1022 | 1022 | ||
| 1023 | 1023 | bool NeedsSourcePositionsForProfiling() const; | |
| 1024 | 1024 | ||
| 1025 | + bool NeedsDetailedOptimizedCodeLineInfo() const; | ||
| 1026 | + | ||
| 1025 | 1027 | bool is_best_effort_code_coverage() const { | |
| 1026 | 1028 | return code_coverage_mode() == debug::Coverage::kBestEffort; | |
| 1027 | 1029 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -39,7 +39,7 @@ OptimizedCompilationInfo::OptimizedCompilationInfo( | |||
| 39 | 39 | // Collect source positions for optimized code when profiling or if debugger | |
| 40 | 40 | // is active, to be able to get more precise source positions at the price of | |
| 41 | 41 | // more memory consumption. | |
| 42 | - if (isolate->NeedsSourcePositionsForProfiling()) { | ||
| 42 | + if (isolate->NeedsDetailedOptimizedCodeLineInfo()) { | ||
| 43 | 43 | MarkAsSourcePositionsEnabled(); | |
| 44 | 44 | } | |
| 45 | 45 | ||
0 commit comments