tools: ignore CVE mention when linting release proposals · nodejs/node@6a8a73a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 6a8a73a

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

committed

tools: ignore CVE mention when linting release proposals

PR-URL: #59037 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

1 parent 3e9ed4b commit 6a8a73a
Copy full SHA for 6a8a73a

2 files changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • lint-release-proposal.yml
• tools/actions
  • lint-release-proposal-commit-list.mjs

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/lint-release-proposal.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/lint-release-proposal.yml

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -39,7 +39,7 @@ jobs:
39	39	EXPECTED_TRAILER="^$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/pull/[[:digit:]]+\$"
40	40	echo "Expected trailer format: $EXPECTED_TRAILER"
41	41	PR_URL="$(git --no-pager log -1 --format='%(trailers:key=PR-URL,valueonly)')"
42		- echo "Actual: $ACTUAL"
	42	+ echo "Actual: $PR_URL"
43	43	echo "$PR_URL" | grep -E -q "$EXPECTED_TRAILER"
44	44
45	45	PR_HEAD="$(gh pr view "$PR_URL" --json headRefOid -q .headRefOid)"

Collapse file

‎tools/actions/lint-release-proposal-commit-list.mjs‎

Copy file name to clipboardExpand all lines: tools/actions/lint-release-proposal-commit-list.mjs

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -34,6 +34,7 @@ if (commitListingStart === -1) {
34	34	// Normalize for consistent comparison
35	35	commitList = commitList
36	36	.replaceAll('**(SEMVER-MINOR)** ', '')
	37	+ .replaceAll(/(?<= - )\*\*\(CVE-\d{4}-\d+\)\*\* (?=\*\*)/g, '')
37	38	.replaceAll('\\', '');
38	39
39	40	let expectedNumberOfCommitsLeft = commitList.match(/\n\* \[/g)?.length ?? 0;

0 commit comments

Comments

0 (0)