Commit 6b54024
test: use realpath for NODE_TEST_DIR in common.js
If you don't specify NODE_TEST_DIR, common.tmpDir will resolve to the
realpath of `node/test`.
If you do specify NODE_TEST_DIR (with the environment variable or by
running or by running tools/test.py --test-dir=x), common.tmpDir (which
is resolved from testRoot) uses the symbolic path (doesn't resolve
symlinks). This uses fs.realpathSync() to fix that.
PR-URL: #10723
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent c6aeb44 commit 6b54024
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -366,7 +366,7 @@ Synchronous version of `spawnPwd`. | |||
| 366 | 366 | ### tmpDir | |
| 367 | 367 | * return [<String>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#String_type) | |
| 368 | 368 | ||
| 369 | - Path to the 'tmp' directory. | ||
| 369 | + The realpath of the 'tmp' directory. | ||
| 370 | 370 | ||
| 371 | 371 | ### tmpDirName | |
| 372 | 372 | * return [<String>](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures#String_type) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -10,7 +10,7 @@ const util = require('util'); | |||
| 10 | 10 | const Timer = process.binding('timer_wrap').Timer; | |
| 11 | 11 | ||
| 12 | 12 | const testRoot = process.env.NODE_TEST_DIR ? | |
| 13 | - path.resolve(process.env.NODE_TEST_DIR) : __dirname; | ||
| 13 | + fs.realpathSync(process.env.NODE_TEST_DIR) : __dirname; | ||
| 14 | 14 | ||
| 15 | 15 | exports.fixturesDir = path.join(__dirname, 'fixtures'); | |
| 16 | 16 | exports.tmpDirName = 'tmp'; | |
0 commit comments