http: fix `close` return value mismatch between doc and implementation · nodejs/node@6bf148e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 6bf148e

Browse filesBrowse the repository at this point in the historyBrowse files

kylo5aby

authored and

richardlau

committed

http: fix close return value mismatch between doc and implementation

PR-URL: #51797 Fixes: #51787 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

1 parent cea90dc commit 6bf148e
Copy full SHA for 6bf148e

3 files changed

+3Lines changed: 3 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • _http_server.js
  • https.js
• test/parallel
  • test-http-server.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/_http_server.js‎

Copy file name to clipboardExpand all lines: lib/_http_server.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -561,6 +561,7 @@ ObjectSetPrototypeOf(Server, net.Server);
561	561	Server.prototype.close = function() {
562	562	httpServerPreClose(this);
563	563	ReflectApply(net.Server.prototype.close, this, arguments);
	564	+ return this;
564	565	};
565	566
566	567	Server.prototype[SymbolAsyncDispose] = async function() {

Collapse file

‎lib/https.js‎

Copy file name to clipboardExpand all lines: lib/https.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -111,6 +111,7 @@ Server.prototype.setTimeout = HttpServer.prototype.setTimeout;
111	111	Server.prototype.close = function() {
112	112	httpServerPreClose(this);
113	113	ReflectApply(tls.Server.prototype.close, this, arguments);
	114	+ return this;
114	115	};
115	116
116	117	Server.prototype[SymbolAsyncDispose] = async function() {

Collapse file

‎test/parallel/test-http-server.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-server.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -139,4 +139,5 @@ process.on('exit', function() {
139	139	assert.match(server_response, quit);
140	140
141	141	assert.strictEqual(client_got_eof, true);
	142	+ assert.strictEqual(server.close(), server);
142	143	});

0 commit comments

Comments

0 (0)