crypto: fix label cast in EVP_PKEY_CTX_set0_rsa_oaep_label · nodejs/node@6d5dc63 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 6d5dc63

Browse filesBrowse the repository at this point in the historyBrowse files

codebytere

authored and

targos

committed

crypto: fix label cast in EVP_PKEY_CTX_set0_rsa_oaep_label

PR-URL: #38926 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

1 parent 6e93c17 commit 6d5dc63
Copy full SHA for 6d5dc63

2 files changed

+5-2Lines changed: 5 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src/crypto
  • crypto_cipher.cc
  • crypto_rsa.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/crypto/crypto_cipher.cc‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_cipher.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -906,7 +906,7 @@ bool PublicKeyCipher::Cipher(
906	906	void* label = OPENSSL_memdup(oaep_label.data(), oaep_label.size());
907	907	CHECK_NOT_NULL(label);
908	908	if (0 >= EVP_PKEY_CTX_set0_rsa_oaep_label(ctx.get(),
909		- reinterpret_cast<unsigned char*>(label),
	909	+ static_cast<unsigned char*>(label),
910	910	oaep_label.size())) {
911	911	OPENSSL_free(label);
912	912	return false;

Collapse file

‎src/crypto/crypto_rsa.cc‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_rsa.cc

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -210,7 +210,10 @@ WebCryptoCipherStatus RSA_Cipher(
210	210	if (label_len > 0) {
211	211	void* label = OPENSSL_memdup(params.label.get(), label_len);
212	212	CHECK_NOT_NULL(label);
213		- if (EVP_PKEY_CTX_set0_rsa_oaep_label(ctx.get(), label, label_len) <= 0) {
	213	+ if (EVP_PKEY_CTX_set0_rsa_oaep_label(
	214	+ ctx.get(),
	215	+ static_cast<unsigned char*>(label),
	216	+ label_len) <= 0) {
214	217	OPENSSL_free(label);
215	218	return WebCryptoCipherStatus::FAILED;
216	219	}

0 commit comments

Comments

0 (0)