FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: give js-native-api tests consistent names · nodejs/node@6da4aa3 · GitHub

/ node Public

Commit 6da4aa3

Browse files
gabrielschulhof
authored and
danielleadams
committed
test: give js-native-api tests consistent names
The convention for js-native-api/<test_name>: * <test_name>.c or <test_name>.cc has the entry point * The name of the target is <test_name> PR-URL: #38692 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent a47fd67 commit 6da4aa3

24 files changed

Lines changed: 24 additions & 24 deletions

File tree

test/js-native-api/2_function_arguments/binding.c renamed to test/js-native-api/2_function_arguments/2_function_arguments.c

File renamed without changes.

‎test/js-native-api/2_function_arguments/binding.gyp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"targets": [
33
{
4-
"target_name": "binding",
4+
"target_name": "2_function_arguments",
55
"sources": [
66
"../entry_point.c",
7-
"binding.c"
7+
"2_function_arguments.c"
88
]
99
}
1010
]

‎test/js-native-api/2_function_arguments/test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22
const common = require('../../common');
33
const assert = require('assert');
4-
const addon = require(`./build/${common.buildType}/binding`);
4+
const addon = require(`./build/${common.buildType}/2_function_arguments`);
55

66
assert.strictEqual(addon.add(3, 5), 8);

test/js-native-api/3_callbacks/binding.c renamed to test/js-native-api/3_callbacks/3_callbacks.c

File renamed without changes.

‎test/js-native-api/3_callbacks/binding.gyp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"targets": [
33
{
4-
"target_name": "binding",
4+
"target_name": "3_callbacks",
55
"sources": [
66
"../entry_point.c",
7-
"binding.c"
7+
"3_callbacks.c"
88
]
99
}
1010
]

‎test/js-native-api/3_callbacks/test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22
const common = require('../../common');
33
const assert = require('assert');
4-
const addon = require(`./build/${common.buildType}/binding`);
4+
const addon = require(`./build/${common.buildType}/3_callbacks`);
55

66
addon.RunCallback(function(msg) {
77
assert.strictEqual(msg, 'hello world');

test/js-native-api/4_object_factory/binding.c renamed to test/js-native-api/4_object_factory/4_object_factory.c

File renamed without changes.

‎test/js-native-api/4_object_factory/binding.gyp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"targets": [
33
{
4-
"target_name": "binding",
4+
"target_name": "4_object_factory",
55
"sources": [
66
"../entry_point.c",
7-
"binding.c"
7+
"4_object_factory.c"
88
]
99
}
1010
]

‎test/js-native-api/4_object_factory/test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22
const common = require('../../common');
33
const assert = require('assert');
4-
const addon = require(`./build/${common.buildType}/binding`);
4+
const addon = require(`./build/${common.buildType}/4_object_factory`);
55

66
const obj1 = addon('hello');
77
const obj2 = addon('world');

test/js-native-api/5_function_factory/binding.c renamed to test/js-native-api/5_function_factory/5_function_factory.c

File renamed without changes.

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL