Commit 6dc2a99
tools: validate release commit diff as part of lint-release-proposal
PR-URL: #61440
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>1 parent f660560 commit 6dc2a99
1 file changed
Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -26,6 +26,7 @@ jobs: | |||
| 26 | 26 | - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |
| 27 | 27 | with: | |
| 28 | 28 | persist-credentials: false | |
| 29 | + fetch-depth: 2 | ||
| 29 | 30 | - name: Lint release commit title format | |
| 30 | 31 | run: | | |
| 31 | 32 | EXPECTED_TITLE='^[[:digit:]]{4}-[[:digit:]]{2}-[[:digit:]]{2}, Version [[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+ (\(Current|'.+' \(LTS)\)$' | |
@@ -51,6 +52,29 @@ jobs: | |||
| 51 | 52 | - name: Verify it's release-ready | |
| 52 | 53 | run: | | |
| 53 | 54 | SKIP_XZ=1 make release-only | |
| 55 | + - name: Lint release commit content | ||
| 56 | + run: | | ||
| 57 | + MAJOR="$(awk '/^#define NODE_MAJOR_VERSION / { print $3 }' src/node_version.h)" | ||
| 58 | + | ||
| 59 | + echo "Checking for expected files in the release commit:" | ||
| 60 | + missing_expected= | ||
| 61 | + for expected in CHANGELOG.md src/node_version.h doc/changelogs/; do | ||
| 62 | + if git diff --exit-code --quiet --diff-filter=M HEAD^ -- "$expected"; then | ||
| 63 | + echo "Missing expected file in diff: $expected" | ||
| 64 | + missing_expected=1 | ||
| 65 | + fi | ||
| 66 | + done | ||
| 67 | + [ -z "$missing_expected" ] || exit 1 | ||
| 68 | + | ||
| 69 | + echo "Checking for unexpected files in the release commit:" | ||
| 70 | + set -ex | ||
| 71 | + [ -z "$(git diff-tree --no-commit-id --name-only -r HEAD --\ | ||
| 72 | + . \ | ||
| 73 | + ':(exclude)CHANGELOG.md' \ | ||
| 74 | + ':(exclude)src/node_version.h' \ | ||
| 75 | + ':(exclude)test/parallel/test-process-release.js' \ | ||
| 76 | + ':(exclude)doc/api/' \ | ||
| 77 | + ":(exclude)doc/changelogs/CHANGELOG_V$MAJOR.md")" ] | ||
| 54 | 78 | - name: Validate CHANGELOG | |
| 55 | 79 | id: releaser-info | |
| 56 | 80 | run: | | |
0 commit comments