test: skip test-child-process-stdio-reuse-readable-stdio on Windows · nodejs/node@6e56f2d · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 6e56f2d

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

ruyadorno

committed

test: skip test-child-process-stdio-reuse-readable-stdio on Windows

It is flaky due to the same cause of test-child-process-pipe-dataflow being flaky - cygwin quirks - so skip it on Windows too. Drive-by: remove the skip mark of test-child-process-pipe-dataflow in the status file and directly skip it in the test with a comment. PR-URL: #49621 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

1 parent c2eac7d commit 6e56f2d
Copy full SHA for 6e56f2d

3 files changed

+12-3Lines changed: 12 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • parallel.status
  • test-child-process-pipe-dataflow.js
  • test-child-process-stdio-reuse-readable-stdio.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/parallel.status‎

Copy file name to clipboardExpand all lines: test/parallel/parallel.status

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -11,9 +11,6 @@ prefix parallel
11	11	test-crypto-keygen: PASS,FLAKY
12	12	# https://github.com/nodejs/node/issues/41201
13	13	test-fs-rmdir-recursive: PASS, FLAKY
14		- # https://github.com/nodejs/node/issues/48300
15		- test-child-process-pipe-dataflow: SKIP
16		- test-child-process-stdio-reuse-readable-stdio: PASS, FLAKY
17	14
18	15	# Windows on ARM
19	16	[$system==win32 && $arch==arm64]

Collapse file

‎test/parallel/test-child-process-pipe-dataflow.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-pipe-dataflow.js

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,5 +1,11 @@
1	1	'use strict';
2	2	const common = require('../common');
	3	+
	4	+ if (common.isWindows) {
	5	+ // https://github.com/nodejs/node/issues/48300
	6	+ common.skip('Does not work with cygwin quirks on Windows');
	7	+ }
	8	+
3	9	const assert = require('assert');
4	10	const fs = require('fs');
5	11	const spawn = require('child_process').spawn;

Collapse file

‎test/parallel/test-child-process-stdio-reuse-readable-stdio.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-stdio-reuse-readable-stdio.js

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,5 +1,11 @@
1	1	'use strict';
2	2	const common = require('../common');
	3	+
	4	+ if (common.isWindows) {
	5	+ // https://github.com/nodejs/node/issues/48300
	6	+ common.skip('Does not work with cygwin quirks on Windows');
	7	+ }
	8	+
3	9	const assert = require('assert');
4	10	const { spawn } = require('child_process');
5	11

0 commit comments

Comments

0 (0)