Commit 6e9676e
node-api: generalize finalizer second pass callback
Generalize the finalizer's second pass callback to make it
cancellable and simplify the code around the second pass callback.
With this change, it is determined that Reference::Finalize or
RefBase::Finalize are called once, either from the env's shutdown,
or from the env's second pass callback.
All existing node-api js tests should pass without a touch. The
js_native_api cctest is no longer applicable with this change,
just removing it.
PR-URL: #44141
Refs: #44071
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent 14c95ec commit 6e9676e
8 files changed
Lines changed: 317 additions & 413 deletions
File tree
- src
- test
- cctest
- js-native-api/6_object_wrap
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1241,7 +1241,6 @@ | |||
| 1241 | 1241 | 'test/cctest/test_base_object_ptr.cc', | |
| 1242 | 1242 | 'test/cctest/test_node_postmortem_metadata.cc', | |
| 1243 | 1243 | 'test/cctest/test_environment.cc', | |
| 1244 | - 'test/cctest/test_js_native_api_v8.cc', | ||
| 1245 | 1244 | 'test/cctest/test_linked_binding.cc', | |
| 1246 | 1245 | 'test/cctest/test_node_api.cc', | |
| 1247 | 1246 | 'test/cctest/test_per_process.cc', | |
0 commit comments