Commit 6eb1c25
tools: ignore URLs in line length linting
Where inclusion of a lengthy URL causes a line to exceed 80 characters
in our code base, do not report the line length as a linting error.
PR-URL: #11890
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>1 parent 8d1a474 commit 6eb1c25
3 files changed
Lines changed: 1 addition & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -96,7 +96,7 @@ rules: | |||
| 96 | 96 | key-spacing: [2, {mode: minimum}] | |
| 97 | 97 | keyword-spacing: 2 | |
| 98 | 98 | linebreak-style: [2, unix] | |
| 99 | - max-len: [2, 80, 2] | ||
| 99 | + max-len: [2, {code: 80, ignoreUrls: true, tabWidth: 2}] | ||
| 100 | 100 | new-parens: 2 | |
| 101 | 101 | no-mixed-spaces-and-tabs: 2 | |
| 102 | 102 | no-multiple-empty-lines: [2, {max: 2, maxEOF: 0, maxBOF: 0}] | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -234,11 +234,9 @@ function Server(requestListener) { | |||
| 234 | 234 | this.addListener('request', requestListener); | |
| 235 | 235 | } | |
| 236 | 236 | ||
| 237 | - /* eslint-disable max-len */ | ||
| 238 | 237 | // Similar option to this. Too lazy to write my own docs. | |
| 239 | 238 | // http://www.squid-cache.org/Doc/config/half_closed_clients/ | |
| 240 | 239 | // http://wiki.squid-cache.org/SquidFaq/InnerWorkings#What_is_a_half-closed_filedescriptor.3F | |
| 241 | - /* eslint-enable max-len */ | ||
| 242 | 240 | this.httpAllowHalfOpen = false; | |
| 243 | 241 | ||
| 244 | 242 | this.addListener('connection', connectionListener); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -49,7 +49,6 @@ if (process.argv[2] === 'you-are-the-child') { | |||
| 49 | 49 | delete process.env.NON_EXISTING_VARIABLE; | |
| 50 | 50 | assert.strictEqual(true, delete process.env.NON_EXISTING_VARIABLE); | |
| 51 | 51 | ||
| 52 | - /* eslint-disable max-len */ | ||
| 53 | 52 | /* For the moment we are not going to support setting the timezone via the | |
| 54 | 53 | * environment variables. The problem is that various V8 platform backends | |
| 55 | 54 | * deal with timezone in different ways. The windows platform backend caches | |
@@ -66,7 +65,6 @@ date = new Date('Fri, 10 Sep 1982 03:15:00 GMT'); | |||
| 66 | 65 | assert.strictEqual(3, date.getUTCHours()); | |
| 67 | 66 | assert.strictEqual(5, date.getHours()); | |
| 68 | 67 | */ | |
| 69 | - /* eslint-enable max-len */ | ||
| 70 | 68 | ||
| 71 | 69 | // Environment variables should be case-insensitive on Windows, and | |
| 72 | 70 | // case-sensitive on other platforms. | |
0 commit comments