util: inspect: do not crash on an Error stack pointing to itself · nodejs/node@6f7b895 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 6f7b895

Browse filesBrowse the repository at this point in the historyBrowse files

SamVerschueren

authored and

RafaelGSS

committed

util: inspect: do not crash on an Error stack pointing to itself

PR-URL: #58196 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

1 parent fb4378b commit 6f7b895
Copy full SHA for 6f7b895

2 files changed

+37-4Lines changed: 37 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/util
  • inspect.js
• test/parallel
  • test-util-inspect.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/util/inspect.js‎

Copy file name to clipboardExpand all lines: lib/internal/util/inspect.js

+6-1Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1319,7 +1319,12 @@ function getStackString(ctx, error) {
1319	1319	if (typeof error.stack === 'string') {
1320	1320	return error.stack;
1321	1321	}
1322		- return formatValue(ctx, error.stack);
	1322	+ ctx.seen.push(error);
	1323	+ ctx.indentationLvl += 4;
	1324	+ const result = formatValue(ctx, error.stack);
	1325	+ ctx.indentationLvl -= 4;
	1326	+ ctx.seen.pop();
	1327	+ return `${ErrorPrototypeToString(error)}\n ${result}`;
1323	1328	}
1324	1329	return ErrorPrototypeToString(error);
1325	1330	}

Collapse file

‎test/parallel/test-util-inspect.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-util-inspect.js

+31-3Lines changed: 31 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -770,14 +770,14 @@ assert.strictEqual(util.inspect(-5e-324), '-5e-324');
770	770	// Note: Symbols are not supported by `Error#toString()` which is called by
771	771	// accessing the `stack` property.
772	772	[
773		- [404, '404 [RangeError]: foo', '[404]'],
	773	+ [404, '404 [RangeError]: foo', '[RangeError: foo\n 404]'],
774	774	[0, '0 [RangeError]: foo', '[RangeError: foo]'],
775	775	[0n, '0 [RangeError]: foo', '[RangeError: foo]'],
776	776	[null, 'null: foo', '[RangeError: foo]'],
777	777	[undefined, 'RangeError: foo', '[RangeError: foo]'],
778	778	[false, 'false [RangeError]: foo', '[RangeError: foo]'],
779	779	['', 'foo', '[RangeError: foo]'],
780		- [[1, 2, 3], '1,2,3 [RangeError]: foo', '[[\n 1,\n 2,\n 3\n]]'],
	780	+ [[1, 2, 3], '1,2,3 [RangeError]: foo', '[RangeError: foo\n [\n 1,\n 2,\n 3\n ]]'],
781	781	].forEach(([value, outputStart, stack]) => {
782	782	let err = new RangeError('foo');
783	783	err.name = value;
@@ -3457,6 +3457,34 @@ ${error.stack.split('\n').slice(1).join('\n')}`,
3457	3457
3458	3458	assert.strictEqual(
3459	3459	inspect(error),
3460		- '[[\n Symbol(foo)\n]]'
	3460	+ '[Error\n [\n Symbol(foo)\n ]]'
3461	3461	);
3462	3462	}
	3463	+
	3464	+ {
	3465	+ const prepareStackTrace = Error.prepareStackTrace;
	3466	+
	3467	+ Error.prepareStackTrace = (error) => error;
	3468	+
	3469	+ const error = new Error('foo');
	3470	+
	3471	+ assert.strictEqual(inspect(error), '[Error: foo\n [Circular *1]]');
	3472	+
	3473	+ Error.prepareStackTrace = prepareStackTrace;
	3474	+ }
	3475	+
	3476	+ {
	3477	+ const error = new Error('foo');
	3478	+ error.stack = error;
	3479	+
	3480	+ assert.strictEqual(inspect(error), '[Error: foo\n [Circular *1]]');
	3481	+ }
	3482	+
	3483	+ {
	3484	+ const error = new Error('foo');
	3485	+ const error2 = new Error('bar');
	3486	+ error.stack = error2;
	3487	+ error2.stack = error;
	3488	+
	3489	+ assert.strictEqual(inspect(error), '[Error: foo\n [Error: bar\n [Circular *1]]]');
	3490	+ }

0 commit comments

Comments

0 (0)