Commit 708fd19
authored
src: remove node.h APIs to make callback without an async context
PR-URL: #58471
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>1 parent 25f2f27 commit 708fd19
2 files changed
Lines changed: 0 additions & 65 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,7 +7,6 @@ | |||
| 7 | 7 | namespace node { | |
| 8 | 8 | ||
| 9 | 9 | using v8::Context; | |
| 10 | - using v8::EscapableHandleScope; | ||
| 11 | 10 | using v8::Function; | |
| 12 | 11 | using v8::HandleScope; | |
| 13 | 12 | using v8::Isolate; | |
@@ -362,39 +361,4 @@ MaybeLocal<Value> MakeSyncCallback(Isolate* isolate, | |||
| 362 | 361 | return ret; | |
| 363 | 362 | } | |
| 364 | 363 | ||
| 365 | - // Legacy MakeCallback()s | ||
| 366 | - | ||
| 367 | - Local<Value> MakeCallback(Isolate* isolate, | ||
| 368 | - Local<Object> recv, | ||
| 369 | - const char* method, | ||
| 370 | - int argc, | ||
| 371 | - Local<Value>* argv) { | ||
| 372 | - EscapableHandleScope handle_scope(isolate); | ||
| 373 | - return handle_scope.Escape( | ||
| 374 | - MakeCallback(isolate, recv, method, argc, argv, {0, 0}) | ||
| 375 | - .FromMaybe(Local<Value>())); | ||
| 376 | - } | ||
| 377 | - | ||
| 378 | - Local<Value> MakeCallback(Isolate* isolate, | ||
| 379 | - Local<Object> recv, | ||
| 380 | - Local<String> symbol, | ||
| 381 | - int argc, | ||
| 382 | - Local<Value>* argv) { | ||
| 383 | - EscapableHandleScope handle_scope(isolate); | ||
| 384 | - return handle_scope.Escape( | ||
| 385 | - MakeCallback(isolate, recv, symbol, argc, argv, {0, 0}) | ||
| 386 | - .FromMaybe(Local<Value>())); | ||
| 387 | - } | ||
| 388 | - | ||
| 389 | - Local<Value> MakeCallback(Isolate* isolate, | ||
| 390 | - Local<Object> recv, | ||
| 391 | - Local<Function> callback, | ||
| 392 | - int argc, | ||
| 393 | - Local<Value>* argv) { | ||
| 394 | - EscapableHandleScope handle_scope(isolate); | ||
| 395 | - return handle_scope.Escape( | ||
| 396 | - MakeCallback(isolate, recv, callback, argc, argv, {0, 0}) | ||
| 397 | - .FromMaybe(Local<Value>())); | ||
| 398 | - } | ||
| 399 | - | ||
| 400 | 364 | } // namespace node | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -175,35 +175,6 @@ NODE_DEPRECATED("Use UVException(isolate, ...)", | |||
| 175 | 175 | path); | |
| 176 | 176 | }) | |
| 177 | 177 | ||
| 178 | - /* | ||
| 179 | - * These methods need to be called in a HandleScope. | ||
| 180 | - * | ||
| 181 | - * It is preferred that you use the `MakeCallback` overloads taking | ||
| 182 | - * `async_context` arguments. | ||
| 183 | - */ | ||
| 184 | - | ||
| 185 | - NODE_DEPRECATED("Use MakeCallback(..., async_context)", | ||
| 186 | - NODE_EXTERN v8::Local<v8::Value> MakeCallback( | ||
| 187 | - v8::Isolate* isolate, | ||
| 188 | - v8::Local<v8::Object> recv, | ||
| 189 | - const char* method, | ||
| 190 | - int argc, | ||
| 191 | - v8::Local<v8::Value>* argv)); | ||
| 192 | - NODE_DEPRECATED("Use MakeCallback(..., async_context)", | ||
| 193 | - NODE_EXTERN v8::Local<v8::Value> MakeCallback( | ||
| 194 | - v8::Isolate* isolate, | ||
| 195 | - v8::Local<v8::Object> recv, | ||
| 196 | - v8::Local<v8::String> symbol, | ||
| 197 | - int argc, | ||
| 198 | - v8::Local<v8::Value>* argv)); | ||
| 199 | - NODE_DEPRECATED("Use MakeCallback(..., async_context)", | ||
| 200 | - NODE_EXTERN v8::Local<v8::Value> MakeCallback( | ||
| 201 | - v8::Isolate* isolate, | ||
| 202 | - v8::Local<v8::Object> recv, | ||
| 203 | - v8::Local<v8::Function> callback, | ||
| 204 | - int argc, | ||
| 205 | - v8::Local<v8::Value>* argv)); | ||
| 206 | - | ||
| 207 | 178 | } // namespace node | |
| 208 | 179 | ||
| 209 | 180 | #include <cassert> | |
0 commit comments