doc: improve code snippet alternative of url.parse() using WHATWG URL · nodejs/node@70c2080 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 70c2080

Browse filesBrowse the repository at this point in the historyBrowse files

styfle

authored and

aduh95

committed

doc: improve code snippet alternative of url.parse() using WHATWG URL

PR-URL: #60209 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent beadcf1 commit 70c2080
Copy full SHA for 70c2080

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • url.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/url.md‎

Copy file name to clipboardExpand all lines: doc/api/url.md

+2-2Lines changed: 2 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -1847,7 +1847,7 @@ input. CVEs are not issued for `url.parse()` vulnerabilities. Use the
1847	1847	function getURL(req) {
1848	1848	const proto = req.headers['x-forwarded-proto'] || 'https';
1849	1849	const host = req.headers['x-forwarded-host'] || req.headers.host || 'example.com';
1850		- return new URL(req.url || '/', `${proto}://${host}`);
	1850	+ return new URL(`${proto}://${host}${req.url || '/'}`);
1851	1851	}
1852	1852	```
1853	1853
@@ -1857,7 +1857,7 @@ use the example below:
1857	1857
1858	1858	```js
1859	1859	function getURL(req) {
1860		- return new URL(req.url || '/', 'https://example.com');
	1860	+ return new URL(`https://example.com${req.url || '/'}`);
1861	1861	}
1862	1862	```
1863	1863

0 commit comments

Comments

0 (0)