Commit 70c41a8
stream: remove redundant context from comments
Using the variable name in the comment and justifying the type seems
redundant to me and instead it should defined the entity which it is
acting, like in our case it is acting as a flag to control the flow in
streams.
PR-URL: #35728
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>1 parent a41e3eb commit 70c41a8
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,11 +38,11 @@ function from(Readable, iterable, opts) { | |||
| 38 | 38 | ...opts | |
| 39 | 39 | }); | |
| 40 | 40 | ||
| 41 | - // Reading boolean to protect against _read | ||
| 41 | + // Flag to protect against _read | ||
| 42 | 42 | // being called before last iteration completion. | |
| 43 | 43 | let reading = false; | |
| 44 | 44 | ||
| 45 | - // needToClose boolean if iterator needs to be explicitly closed | ||
| 45 | + // Flag for when iterator needs to be explicitly closed. | ||
| 46 | 46 | let needToClose = false; | |
| 47 | 47 | ||
| 48 | 48 | readable._read = function() { | |
0 commit comments