tools: fix `--node-builtin-modules-path` value in `shell.nix` · nodejs/node@710dde5 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 710dde5

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

committed

tools: fix --node-builtin-modules-path value in shell.nix

PR-URL: #62102 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

1 parent b26d1c7 commit 710dde5
Copy full SHA for 710dde5

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• shell.nix

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎shell.nix‎

Copy file name to clipboardExpand all lines: shell.nix

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -64,7 +64,7 @@ let
64	64	++ pkgs.lib.optional (!withSSL) "--without-ssl"
65	65	++ pkgs.lib.optional withTemporal "--v8-enable-temporal-support"
66	66	++ pkgs.lib.optional (ninja != null) "--ninja"
67		- ++ pkgs.lib.optional loadJSBuiltinsDynamically "--node-builtin-modules-path=${builtins.toString ../..}"
	67	+ ++ pkgs.lib.optional loadJSBuiltinsDynamically "--node-builtin-modules-path=${builtins.toString ./.}"
68	68	++ pkgs.lib.concatMap (name: [
69	69	"--shared-${name}"
70	70	"--shared-${name}-libpath=${pkgs.lib.getLib sharedLibDeps.${name}}/lib"

0 commit comments

Comments

0 (0)