Commit 7165f1d
test: improve the code in test-process-cpuUsage
* validate the errors for assert.throws
* use arrow functions
PR-URL: #10714
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent b5c0b43 commit 7165f1d
1 file changed
Lines changed: 42 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -33,27 +33,57 @@ for (let i = 0; i < 10; i++) { | |||
| 33 | 33 | assert(diffUsage.system >= 0); | |
| 34 | 34 | } | |
| 35 | 35 | ||
| 36 | + const invalidUserArgument = | ||
| 37 | + /^TypeError: value of user property of argument is invalid$/; | ||
| 38 | + const invalidSystemArgument = | ||
| 39 | + /^TypeError: value of system property of argument is invalid$/; | ||
| 40 | + | ||
| 36 | 41 | // Ensure that an invalid shape for the previous value argument throws an error. | |
| 37 | - assert.throws(function() { process.cpuUsage(1); }); | ||
| 38 | - assert.throws(function() { process.cpuUsage({}); }); | ||
| 39 | - assert.throws(function() { process.cpuUsage({ user: 'a' }); }); | ||
| 40 | - assert.throws(function() { process.cpuUsage({ system: 'b' }); }); | ||
| 41 | - assert.throws(function() { process.cpuUsage({ user: null, system: 'c' }); }); | ||
| 42 | - assert.throws(function() { process.cpuUsage({ user: 'd', system: null }); }); | ||
| 43 | - assert.throws(function() { process.cpuUsage({ user: -1, system: 2 }); }); | ||
| 44 | - assert.throws(function() { process.cpuUsage({ user: 3, system: -2 }); }); | ||
| 45 | - assert.throws(function() { | ||
| 42 | + assert.throws(() => { | ||
| 43 | + process.cpuUsage(1); | ||
| 44 | + }, invalidUserArgument); | ||
| 45 | + | ||
| 46 | + assert.throws(() => { | ||
| 47 | + process.cpuUsage({}); | ||
| 48 | + }, invalidUserArgument); | ||
| 49 | + | ||
| 50 | + assert.throws(() => { | ||
| 51 | + process.cpuUsage({ user: 'a' }); | ||
| 52 | + }, invalidUserArgument); | ||
| 53 | + | ||
| 54 | + assert.throws(() => { | ||
| 55 | + process.cpuUsage({ system: 'b' }); | ||
| 56 | + }, invalidUserArgument); | ||
| 57 | + | ||
| 58 | + assert.throws(() => { | ||
| 59 | + process.cpuUsage({ user: null, system: 'c' }); | ||
| 60 | + }, invalidUserArgument); | ||
| 61 | + | ||
| 62 | + assert.throws(() => { | ||
| 63 | + process.cpuUsage({ user: 'd', system: null }); | ||
| 64 | + }, invalidUserArgument); | ||
| 65 | + | ||
| 66 | + assert.throws(() => { | ||
| 67 | + process.cpuUsage({ user: -1, system: 2 }); | ||
| 68 | + }, invalidUserArgument); | ||
| 69 | + | ||
| 70 | + assert.throws(() => { | ||
| 71 | + process.cpuUsage({ user: 3, system: -2 }); | ||
| 72 | + }, invalidSystemArgument); | ||
| 73 | + | ||
| 74 | + assert.throws(() => { | ||
| 46 | 75 | process.cpuUsage({ | |
| 47 | 76 | user: Number.POSITIVE_INFINITY, | |
| 48 | 77 | system: 4 | |
| 49 | 78 | }); | |
| 50 | - }); | ||
| 51 | - assert.throws(function() { | ||
| 79 | + }, invalidUserArgument); | ||
| 80 | + | ||
| 81 | + assert.throws(() => { | ||
| 52 | 82 | process.cpuUsage({ | |
| 53 | 83 | user: 5, | |
| 54 | 84 | system: Number.NEGATIVE_INFINITY | |
| 55 | 85 | }); | |
| 56 | - }); | ||
| 86 | + }, invalidSystemArgument); | ||
| 57 | 87 | ||
| 58 | 88 | // Ensure that the return value is the expected shape. | |
| 59 | 89 | function validateResult(result) { | |
0 commit comments