Commit 7188b95
src: fix -Winconsistent-missing-override warning
This commit addresses the following warning:
../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable'
overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]
v8::Maybe<bool> mark_arraybuffer_as_untransferable(
^
../src/js_native_api_v8.h:42:27: note: overridden virtual function is here
virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable(
PR-URL: #30549
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>1 parent 18ec8a8 commit 7188b95
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -26,7 +26,7 @@ struct node_napi_env__ : public napi_env__ { | |||
| 26 | 26 | } | |
| 27 | 27 | ||
| 28 | 28 | v8::Maybe<bool> mark_arraybuffer_as_untransferable( | |
| 29 | - v8::Local<v8::ArrayBuffer> ab) const { | ||
| 29 | + v8::Local<v8::ArrayBuffer> ab) const override { | ||
| 30 | 30 | return ab->SetPrivate( | |
| 31 | 31 | context(), | |
| 32 | 32 | node_env()->arraybuffer_untransferable_private_symbol(), | |
0 commit comments