quic: remove unused env_ variable in session_manager.h/cc · nodejs/node@72ab744 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 72ab744

Browse filesBrowse the repository at this point in the historyBrowse files

jasnell

authored and

aduh95

committed

quic: remove unused env_ variable in session_manager.h/cc

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #63177 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent 2b55656 commit 72ab744
Copy full SHA for 72ab744

3 files changed

+3-9Lines changed: 3 additions & 9 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src/quic
  • bindingdata.cc
  • session_manager.cc
  • session_manager.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/quic/bindingdata.cc‎

Copy file name to clipboardExpand all lines: src/quic/bindingdata.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -225,7 +225,7 @@ BindingData::BindingData(Realm* realm, Local<Object> object)
225	225
226	226	SessionManager& BindingData::session_manager() {
227	227	if (!session_manager_) {
228		- session_manager_ = std::make_unique<SessionManager>(env());
	228	+ session_manager_ = std::make_unique<SessionManager>();
229	229	}
230	230	return *session_manager_;
231	231	}

Collapse file

‎src/quic/session_manager.cc‎

Copy file name to clipboardExpand all lines: src/quic/session_manager.cc

-4Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -10,10 +10,6 @@
10	10
11	11	namespace node::quic {
12	12
13		- SessionManager::SessionManager(Environment* env) : env_(env) {}
14		-
15		- SessionManager::~SessionManager() = default;
16		-
17	13	BaseObjectPtr<Session> SessionManager::FindSession(const CID& cid) {
18	14	// Direct SCID match.
19	15	auto it = sessions_.find(cid);

Collapse file

‎src/quic/session_manager.h‎

Copy file name to clipboardExpand all lines: src/quic/session_manager.h

+2-4Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -24,8 +24,8 @@ class Session;
24	24	// It is not exposed to JavaScript.
25	25	class SessionManager final {
26	26	public:
27		- explicit SessionManager(Environment* env);
28		- ~SessionManager();
	27	+ explicit SessionManager() = default;
	28	+ ~SessionManager() = default;
29	29
30	30	// Session routing. The sessions_ map holds BaseObjectPtr<Session> (owning
31	31	// references). SessionManager is the single authority for session ownership.
@@ -78,8 +78,6 @@ class SessionManager final {
78	78	bool is_empty() const;
79	79
80	80	private:
81		- Environment* env_;
82		-
83	81	// The sessions_ map holds strong owning references keyed by locally-
84	82	// generated SCIDs. This is the single source of truth for session
85	83	// ownership.

0 commit comments

Comments

0 (0)