Commit 732847f
deps: patch V8 to run on older XCode versions
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
property, which is a fairly new C++ feature, since that requires a newer
XCode version than the minimum requirement in BUILDING.md and thus
breaks CI.
PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 70171d1 commit 732847f
3 files changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.1', | ||
| 39 | + 'v8_embedder_string': '-node.2', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4505,6 +4505,7 @@ GlobalAccessFeedback::GlobalAccessFeedback(PropertyCellRef cell, | |||
| 4505 | 4505 | ||
| 4506 | 4506 | GlobalAccessFeedback::GlobalAccessFeedback(FeedbackSlotKind slot_kind) | |
| 4507 | 4507 | : ProcessedFeedback(kGlobalAccess, slot_kind), | |
| 4508 | + cell_or_context_(base::nullopt), | ||
| 4508 | 4509 | index_and_immutable_(0 /* doesn't matter */) { | |
| 4509 | 4510 | DCHECK(IsGlobalICKind(slot_kind)); | |
| 4510 | 4511 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -296,7 +296,7 @@ Interpreter::NewSourcePositionCollectionJob( | |||
| 296 | 296 | auto job = std::make_unique<InterpreterCompilationJob>(parse_info, literal, | |
| 297 | 297 | allocator, nullptr); | |
| 298 | 298 | job->compilation_info()->SetBytecodeArray(existing_bytecode); | |
| 299 | - return job; | ||
| 299 | + return std::unique_ptr<UnoptimizedCompilationJob> { static_cast<UnoptimizedCompilationJob*>(job.release()) }; | ||
| 300 | 300 | } | |
| 301 | 301 | ||
| 302 | 302 | void Interpreter::ForEachBytecode( | |
0 commit comments