assert: change utils to use index instead of for...of · nodejs/node@73aa0ae · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 73aa0ae

Browse filesBrowse the repository at this point in the historyBrowse files

JinhyeokFang

authored and

aduh95

committed

assert: change utils to use index instead of for...of

PR-URL: #59278 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

1 parent 76dab34 commit 73aa0ae
Copy full SHA for 73aa0ae

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/assert
  • utils.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/assert/utils.js‎

Copy file name to clipboardExpand all lines: lib/internal/assert/utils.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -222,7 +222,8 @@ function getErrMessage(message, fn) {
222	222	}
223	223	const frames = StringPrototypeSplit(message, '\n');
224	224	message = ArrayPrototypeShift(frames);
225		- for (const frame of frames) {
	225	+ for (let i = 0; i < frames.length; i++) {
	226	+ const frame = frames[i];
226	227	let pos = 0;
227	228	while (pos < column && (frame[pos] === ' ' || frame[pos] === '\t')) {
228	229	pos++;

0 commit comments

Comments

0 (0)