Commit 73f2dab
test: fix common.canCreateSymLink() on non-Windows
test/common/README.md indicates that canCreateSymlink() always returns
true on non-Windows platforms. However, prior to this commit, undefined
was being returned. This commit aligns the implementation with the
docs by returning true.
PR-URL: #20511
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 380dfe4 commit 73f2dab
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -518,6 +518,8 @@ exports.canCreateSymLink = function() { | |||
| 518 | 518 | return false; | |
| 519 | 519 | } | |
| 520 | 520 | } | |
| 521 | + // On non-Windows platforms, this always returns `true` | ||
| 522 | + return true; | ||
| 521 | 523 | }; | |
| 522 | 524 | ||
| 523 | 525 | exports.getCallSite = function getCallSite(top) { | |
0 commit comments