lib: use process.nextTick() instead of setImmediate() · nodejs/node@7435284 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 753
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 7435284

Browse filesBrowse the repository at this point in the historyBrowse files

lpinca

authored and

RafaelGSS

committed

lib: use process.nextTick() instead of setImmediate()

Do not delay the call to `stream.end()` too much. PR-URL: #42340 Refs: #42340 (comment) Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent 43db0fb commit 7435284
Copy full SHA for 7435284

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • js_stream_socket.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/js_stream_socket.js‎

Copy file name to clipboardExpand all lines: lib/internal/js_stream_socket.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -141,7 +141,7 @@ class JSStreamSocket extends Socket {
141	141
142	142	const handle = this._handle;
143	143
144		- setImmediate(() => {
	144	+ process.nextTick(() => {
145	145	// Ensure that write is dispatched asynchronously.
146	146	this.stream.end(() => {
147	147	this.finishShutdown(handle, 0);

0 commit comments

Comments

0 (0)