Commit 7478ed0
tools: order dependency jobs alphabetically
Refs: nodejs/security-wg#973
PR-URL: #48184
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>1 parent 15336c3 commit 7478ed0
1 file changed
Lines changed: 95 additions & 93 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -28,6 +28,7 @@ on: | |||
| 28 | 28 | - libuv | |
| 29 | 29 | - lint-md-dependencies | |
| 30 | 30 | - llhttp | |
| 31 | + - minimatch | ||
| 31 | 32 | - nghttp2 | |
| 32 | 33 | - nghttp3 | |
| 33 | 34 | - ngtcp2 | |
@@ -36,6 +37,7 @@ on: | |||
| 36 | 37 | - simdutf | |
| 37 | 38 | - undici | |
| 38 | 39 | - uvwasi | |
| 40 | + - zlib | ||
| 39 | 41 | ||
| 40 | 42 | env: | |
| 41 | 43 | PYTHON_VERSION: '3.11' | |
@@ -51,67 +53,27 @@ jobs: | |||
| 51 | 53 | fail-fast: false # Prevent other jobs from aborting if one fails | |
| 52 | 54 | matrix: | |
| 53 | 55 | include: | |
| 54 | - - id: eslint | ||
| 55 | - subsystem: tools | ||
| 56 | - label: tools | ||
| 56 | + - id: acorn | ||
| 57 | + subsystem: deps | ||
| 58 | + label: dependencies | ||
| 57 | 59 | run: | | |
| 58 | - ./tools/dep_updaters/update-eslint.sh > temp-output | ||
| 60 | + ./tools/dep_updaters/update-acorn.sh > temp-output | ||
| 59 | 61 | cat temp-output | |
| 60 | 62 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 61 | 63 | rm temp-output | |
| 62 | - - id: corepack | ||
| 63 | - subsystem: deps | ||
| 64 | - label: dependencies | ||
| 65 | - run: | | ||
| 66 | - make corepack-update | ||
| 67 | - echo "NEW_VERSION=$(node deps/corepack/dist/corepack.js --version)" >> $GITHUB_ENV | ||
| 68 | - - id: lint-md-dependencies | ||
| 69 | - subsystem: tools | ||
| 70 | - label: tools | ||
| 71 | - run: | | ||
| 72 | - cd tools/lint-md | ||
| 73 | - npm ci | ||
| 74 | - NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs) | ||
| 75 | - if [ "$NEW_VERSION" != "" ]; then | ||
| 76 | - echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV | ||
| 77 | - rm -rf package-lock.json node_modules | ||
| 78 | - # Include $NEW_VERSION to explicitly update the package.json | ||
| 79 | - # entry for the dependency and also so that semver-major updates | ||
| 80 | - # are not skipped. | ||
| 81 | - npm install --ignore-scripts $NEW_VERSION | ||
| 82 | - npm install --ignore-scripts | ||
| 83 | - cd ../.. | ||
| 84 | - make lint-md-rollup | ||
| 85 | - fi | ||
| 86 | - - id: doc | ||
| 87 | - subsystem: tools | ||
| 88 | - label: tools | ||
| 89 | - run: | | ||
| 90 | - cd tools/doc | ||
| 91 | - npm ci | ||
| 92 | - NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs) | ||
| 93 | - if [ "$NEW_VERSION" != "" ]; then | ||
| 94 | - echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV | ||
| 95 | - rm -rf package-lock.json node_modules | ||
| 96 | - # Include $NEW_VERSION to explicitly update the package.json | ||
| 97 | - # entry for the dependency and also so that semver-major updates | ||
| 98 | - # are not skipped. | ||
| 99 | - npm install --ignore-scripts $NEW_VERSION | ||
| 100 | - npm install --ignore-scripts | ||
| 101 | - fi | ||
| 102 | - - id: undici | ||
| 64 | + - id: acorn-walk | ||
| 103 | 65 | subsystem: deps | |
| 104 | 66 | label: dependencies | |
| 105 | 67 | run: | | |
| 106 | - ./tools/dep_updaters/update-undici.sh > temp-output | ||
| 68 | + ./tools/dep_updaters/update-acorn-walk.sh > temp-output | ||
| 107 | 69 | cat temp-output | |
| 108 | 70 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 109 | 71 | rm temp-output | |
| 110 | - - id: postject | ||
| 111 | - subsystem: deps,test | ||
| 112 | - label: test | ||
| 72 | + - id: ada | ||
| 73 | + subsystem: deps | ||
| 74 | + label: dependencies | ||
| 113 | 75 | run: | | |
| 114 | - ./tools/dep_updaters/update-postject.sh > temp-output | ||
| 76 | + ./tools/dep_updaters/update-ada.sh > temp-output | ||
| 115 | 77 | cat temp-output | |
| 116 | 78 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 117 | 79 | rm temp-output | |
@@ -123,96 +85,131 @@ jobs: | |||
| 123 | 85 | cat temp-output | |
| 124 | 86 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 125 | 87 | rm temp-output | |
| 126 | - - id: acorn | ||
| 88 | + - id: brotli | ||
| 127 | 89 | subsystem: deps | |
| 128 | 90 | label: dependencies | |
| 129 | 91 | run: | | |
| 130 | - ./tools/dep_updaters/update-acorn.sh > temp-output | ||
| 92 | + ./tools/dep_updaters/update-brotli.sh > temp-output | ||
| 131 | 93 | cat temp-output | |
| 132 | 94 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 133 | 95 | rm temp-output | |
| 134 | - - id: acorn-walk | ||
| 96 | + - id: c-ares | ||
| 135 | 97 | subsystem: deps | |
| 136 | 98 | label: dependencies | |
| 137 | 99 | run: | | |
| 138 | - ./tools/dep_updaters/update-acorn-walk.sh > temp-output | ||
| 100 | + ./tools/dep_updaters/update-c-ares.sh > temp-output | ||
| 139 | 101 | cat temp-output | |
| 140 | 102 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 141 | 103 | rm temp-output | |
| 142 | - - id: libuv | ||
| 104 | + - id: cjs-module-lexer | ||
| 143 | 105 | subsystem: deps | |
| 144 | 106 | label: dependencies | |
| 145 | 107 | run: | | |
| 146 | - ./tools/dep_updaters/update-libuv.sh > temp-output | ||
| 108 | + ./tools/dep_updaters/update-cjs-module-lexer.sh > temp-output | ||
| 147 | 109 | cat temp-output | |
| 148 | 110 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 149 | 111 | rm temp-output | |
| 150 | - - id: simdutf | ||
| 112 | + - id: corepack | ||
| 151 | 113 | subsystem: deps | |
| 152 | 114 | label: dependencies | |
| 153 | 115 | run: | | |
| 154 | - ./tools/dep_updaters/update-simdutf.sh > temp-output | ||
| 116 | + make corepack-update | ||
| 117 | + echo "NEW_VERSION=$(node deps/corepack/dist/corepack.js --version)" >> $GITHUB_ENV | ||
| 118 | + - id: doc | ||
| 119 | + subsystem: tools | ||
| 120 | + label: tools | ||
| 121 | + run: | | ||
| 122 | + cd tools/doc | ||
| 123 | + npm ci | ||
| 124 | + NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs) | ||
| 125 | + if [ "$NEW_VERSION" != "" ]; then | ||
| 126 | + echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV | ||
| 127 | + rm -rf package-lock.json node_modules | ||
| 128 | + # Include $NEW_VERSION to explicitly update the package.json | ||
| 129 | + # entry for the dependency and also so that semver-major updates | ||
| 130 | + # are not skipped. | ||
| 131 | + npm install --ignore-scripts $NEW_VERSION | ||
| 132 | + npm install --ignore-scripts | ||
| 133 | + fi | ||
| 134 | + - id: eslint | ||
| 135 | + subsystem: tools | ||
| 136 | + label: tools | ||
| 137 | + run: | | ||
| 138 | + ./tools/dep_updaters/update-eslint.sh > temp-output | ||
| 155 | 139 | cat temp-output | |
| 156 | 140 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 157 | 141 | rm temp-output | |
| 158 | - - id: ada | ||
| 142 | + - id: googletest | ||
| 159 | 143 | subsystem: deps | |
| 160 | - label: dependencies | ||
| 144 | + label: dependencies, test | ||
| 161 | 145 | run: | | |
| 162 | - ./tools/dep_updaters/update-ada.sh > temp-output | ||
| 146 | + ./tools/dep_updaters/update-googletest.sh > temp-output | ||
| 163 | 147 | cat temp-output | |
| 164 | 148 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 165 | 149 | rm temp-output | |
| 166 | - - id: nghttp2 | ||
| 150 | + - id: icu | ||
| 167 | 151 | subsystem: deps | |
| 168 | - label: dependencies | ||
| 152 | + label: dependencies, test | ||
| 169 | 153 | run: | | |
| 170 | - ./tools/dep_updaters/update-nghttp2.sh > temp-output | ||
| 154 | + ./tools/dep_updaters/update-icu.sh > temp-output | ||
| 171 | 155 | cat temp-output | |
| 172 | 156 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 173 | 157 | rm temp-output | |
| 174 | - - id: llhttp | ||
| 158 | + - id: libuv | ||
| 175 | 159 | subsystem: deps | |
| 176 | 160 | label: dependencies | |
| 177 | 161 | run: | | |
| 178 | - ./tools/dep_updaters/update-llhttp.sh > temp-output | ||
| 162 | + ./tools/dep_updaters/update-libuv.sh > temp-output | ||
| 179 | 163 | cat temp-output | |
| 180 | 164 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 181 | 165 | rm temp-output | |
| 182 | - - id: c-ares | ||
| 166 | + - id: lint-md-dependencies | ||
| 167 | + subsystem: tools | ||
| 168 | + label: tools | ||
| 169 | + run: | | ||
| 170 | + cd tools/lint-md | ||
| 171 | + npm ci | ||
| 172 | + NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs) | ||
| 173 | + if [ "$NEW_VERSION" != "" ]; then | ||
| 174 | + echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV | ||
| 175 | + rm -rf package-lock.json node_modules | ||
| 176 | + # Include $NEW_VERSION to explicitly update the package.json | ||
| 177 | + # entry for the dependency and also so that semver-major updates | ||
| 178 | + # are not skipped. | ||
| 179 | + npm install --ignore-scripts $NEW_VERSION | ||
| 180 | + npm install --ignore-scripts | ||
| 181 | + cd ../.. | ||
| 182 | + make lint-md-rollup | ||
| 183 | + fi | ||
| 184 | + - id: llhttp | ||
| 183 | 185 | subsystem: deps | |
| 184 | 186 | label: dependencies | |
| 185 | 187 | run: | | |
| 186 | - ./tools/dep_updaters/update-c-ares.sh > temp-output | ||
| 188 | + ./tools/dep_updaters/update-llhttp.sh > temp-output | ||
| 187 | 189 | cat temp-output | |
| 188 | 190 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 189 | 191 | rm temp-output | |
| 190 | - - id: brotli | ||
| 192 | + - id: minimatch | ||
| 191 | 193 | subsystem: deps | |
| 192 | 194 | label: dependencies | |
| 193 | 195 | run: | | |
| 194 | - ./tools/dep_updaters/update-brotli.sh > temp-output | ||
| 196 | + ./tools/dep_updaters/update-minimatch.sh > temp-output | ||
| 195 | 197 | cat temp-output | |
| 196 | 198 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 197 | 199 | rm temp-output | |
| 198 | - - id: minimatch | ||
| 200 | + - id: nghttp2 | ||
| 199 | 201 | subsystem: deps | |
| 200 | 202 | label: dependencies | |
| 201 | 203 | run: | | |
| 202 | - ./tools/dep_updaters/update-minimatch.sh > temp-output | ||
| 204 | + ./tools/dep_updaters/update-nghttp2.sh > temp-output | ||
| 203 | 205 | cat temp-output | |
| 204 | 206 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 205 | 207 | rm temp-output | |
| 206 | - - id: root-certificates | ||
| 207 | - subsystem: crypto | ||
| 208 | - label: crypto, notable-change | ||
| 209 | - run: | | ||
| 210 | - node ./tools/dep_updaters/update-root-certs.mjs -v -f "$GITHUB_ENV" | ||
| 211 | - - id: cjs-module-lexer | ||
| 208 | + - id: nghttp3 | ||
| 212 | 209 | subsystem: deps | |
| 213 | 210 | label: dependencies | |
| 214 | 211 | run: | | |
| 215 | - ./tools/dep_updaters/update-cjs-module-lexer.sh > temp-output | ||
| 212 | + ./tools/dep_updaters/update-nghttp3.sh > temp-output | ||
| 216 | 213 | cat temp-output | |
| 217 | 214 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 218 | 215 | rm temp-output | |
@@ -224,43 +221,48 @@ jobs: | |||
| 224 | 221 | cat temp-output | |
| 225 | 222 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 226 | 223 | rm temp-output | |
| 227 | - - id: nghttp3 | ||
| 228 | - subsystem: deps | ||
| 229 | - label: dependencies | ||
| 224 | + - id: postject | ||
| 225 | + subsystem: deps,test | ||
| 226 | + label: test | ||
| 230 | 227 | run: | | |
| 231 | - ./tools/dep_updaters/update-nghttp3.sh > temp-output | ||
| 228 | + ./tools/dep_updaters/update-postject.sh > temp-output | ||
| 232 | 229 | cat temp-output | |
| 233 | 230 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 234 | 231 | rm temp-output | |
| 235 | - - id: uvwasi | ||
| 232 | + - id: root-certificates | ||
| 233 | + subsystem: crypto | ||
| 234 | + label: crypto, notable-change | ||
| 235 | + run: | | ||
| 236 | + node ./tools/dep_updaters/update-root-certs.mjs -v -f "$GITHUB_ENV" | ||
| 237 | + - id: simdutf | ||
| 236 | 238 | subsystem: deps | |
| 237 | 239 | label: dependencies | |
| 238 | 240 | run: | | |
| 239 | - ./tools/dep_updaters/update-uvwasi.sh > temp-output | ||
| 241 | + ./tools/dep_updaters/update-simdutf.sh > temp-output | ||
| 240 | 242 | cat temp-output | |
| 241 | 243 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 242 | 244 | rm temp-output | |
| 243 | - - id: zlib | ||
| 245 | + - id: undici | ||
| 244 | 246 | subsystem: deps | |
| 245 | 247 | label: dependencies | |
| 246 | 248 | run: | | |
| 247 | - ./tools/dep_updaters/update-zlib.sh > temp-output | ||
| 249 | + ./tools/dep_updaters/update-undici.sh > temp-output | ||
| 248 | 250 | cat temp-output | |
| 249 | 251 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 250 | 252 | rm temp-output | |
| 251 | - - id: googletest | ||
| 253 | + - id: uvwasi | ||
| 252 | 254 | subsystem: deps | |
| 253 | - label: dependencies, test | ||
| 255 | + label: dependencies | ||
| 254 | 256 | run: | | |
| 255 | - ./tools/dep_updaters/update-googletest.sh > temp-output | ||
| 257 | + ./tools/dep_updaters/update-uvwasi.sh > temp-output | ||
| 256 | 258 | cat temp-output | |
| 257 | 259 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 258 | 260 | rm temp-output | |
| 259 | - - id: icu | ||
| 261 | + - id: zlib | ||
| 260 | 262 | subsystem: deps | |
| 261 | - label: dependencies, test | ||
| 263 | + label: dependencies | ||
| 262 | 264 | run: | | |
| 263 | - ./tools/dep_updaters/update-icu.sh > temp-output | ||
| 265 | + ./tools/dep_updaters/update-zlib.sh > temp-output | ||
| 264 | 266 | cat temp-output | |
| 265 | 267 | tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |
| 266 | 268 | rm temp-output | |
0 commit comments