FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: prefer in-memory databases in sqlite tests · nodejs/node@74a3e91 · GitHub

/ node Public

Commit 74a3e91

Browse files
bitpshr
authored and
aduh95
committed
test: prefer in-memory databases in sqlite tests
Several SQLite tests created temporary file databases through a `nextDb()` helper even though they only exercise SQL behavior and never rely on filesystem persistence. Switch those to `:memory:`, which is faster and drops the temporary-file bookkeeping. Tests that depend on an on-disk or shared database keep using files: the constructor, open() and backup() cases, the timeout and cross-worker suites, and the WAL journal-mode PRAGMA. Refs: #64665 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #64701 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 5cac7c2 commit 74a3e91

6 files changed

Lines changed: 54 additions & 98 deletions

‎test/parallel/test-sqlite-data-types.js‎

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
11
'use strict';
22
const { skipIfSQLiteMissing } = require('../common');
33
skipIfSQLiteMissing();
4-
const tmpdir = require('../common/tmpdir');
5-
const { join } = require('node:path');
64
const { DatabaseSync } = require('node:sqlite');
75
const { suite, test } = require('node:test');
8-
let cnt = 0;
9-
10-
tmpdir.refresh();
11-
12-
function nextDb() {
13-
return join(tmpdir.path, `database-${cnt++}.db`);
14-
}
156

167
suite('data binding and mapping', () => {
178
test('supported data types', (t) => {
189
const u8a = new TextEncoder().encode('a☃b☃c');
19-
const db = new DatabaseSync(nextDb());
10+
const db = new DatabaseSync(':memory:');
2011
t.after(() => { db.close(); });
2112
const setup = db.exec(`
2213
CREATE TABLE types(
@@ -83,7 +74,7 @@ suite('data binding and mapping', () => {
8374
});
8475

8576
test('large strings are bound correctly', (t) => {
86-
const db = new DatabaseSync(nextDb());
77+
const db = new DatabaseSync(':memory:');
8778
t.after(() => { db.close(); });
8879
const setup = db.exec(
8980
'CREATE TABLE data(key INTEGER PRIMARY KEY, text TEXT) STRICT;'
@@ -118,7 +109,7 @@ suite('data binding and mapping', () => {
118109
});
119110

120111
test('unsupported data types', (t) => {
121-
const db = new DatabaseSync(nextDb());
112+
const db = new DatabaseSync(':memory:');
122113
t.after(() => { db.close(); });
123114
const setup = db.exec(
124115
'CREATE TABLE types(key INTEGER PRIMARY KEY, val INTEGER) STRICT;'
@@ -153,7 +144,7 @@ suite('data binding and mapping', () => {
153144

154145
test('throws when binding a BigInt that is too large', (t) => {
155146
const max = 9223372036854775807n; // Largest 64-bit signed integer value.
156-
const db = new DatabaseSync(nextDb());
147+
const db = new DatabaseSync(':memory:');
157148
t.after(() => { db.close(); });
158149
const setup = db.exec(
159150
'CREATE TABLE types(key INTEGER PRIMARY KEY, val INTEGER) STRICT;'
@@ -173,7 +164,7 @@ suite('data binding and mapping', () => {
173164
});
174165

175166
test('statements are unbound on each call', (t) => {
176-
const db = new DatabaseSync(nextDb());
167+
const db = new DatabaseSync(':memory:');
177168
t.after(() => { db.close(); });
178169
const setup = db.exec(
179170
'CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER) STRICT;'

‎test/parallel/test-sqlite-named-parameters.js‎

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,12 @@
11
'use strict';
22
const { skipIfSQLiteMissing } = require('../common');
33
skipIfSQLiteMissing();
4-
const tmpdir = require('../common/tmpdir');
5-
const { join } = require('node:path');
64
const { DatabaseSync } = require('node:sqlite');
75
const { suite, test } = require('node:test');
8-
let cnt = 0;
9-
10-
tmpdir.refresh();
11-
12-
function nextDb() {
13-
return join(tmpdir.path, `database-${cnt++}.db`);
14-
}
156

167
suite('named parameters', () => {
178
test('throws on unknown named parameters', (t) => {
18-
const db = new DatabaseSync(nextDb());
9+
const db = new DatabaseSync(':memory:');
1910
t.after(() => { db.close(); });
2011
const setup = db.exec(
2112
'CREATE TABLE types(key INTEGER PRIMARY KEY, val INTEGER) STRICT;'
@@ -32,7 +23,7 @@ suite('named parameters', () => {
3223
});
3324

3425
test('bare named parameters are supported', (t) => {
35-
const db = new DatabaseSync(nextDb());
26+
const db = new DatabaseSync(':memory:');
3627
t.after(() => { db.close(); });
3728
const setup = db.exec(
3829
'CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER) STRICT;'
@@ -47,7 +38,7 @@ suite('named parameters', () => {
4738
});
4839

4940
test('duplicate bare named parameters are supported', (t) => {
50-
const db = new DatabaseSync(nextDb());
41+
const db = new DatabaseSync(':memory:');
5142
t.after(() => { db.close(); });
5243
const setup = db.exec(
5344
'CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER) STRICT;'
@@ -62,7 +53,7 @@ suite('named parameters', () => {
6253
});
6354

6455
test('bare named parameters throw on ambiguous names', (t) => {
65-
const db = new DatabaseSync(nextDb());
56+
const db = new DatabaseSync(':memory:');
6657
t.after(() => { db.close(); });
6758
const setup = db.exec(
6859
'CREATE TABLE types(key INTEGER PRIMARY KEY, val INTEGER) STRICT;'

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL