Commit 75af859
assert: apply minor refactoring
* Remove comment referring to the CommonJS Unit Testing 1.0 spec. This
module is no longer intended to comply with that spec.
* Remove puzzling "THIS IS NOT TESTED NOR LIKELY TO WORK OUTSIDE V8!"
comment. No doubt, it made sense at one time.
* Favor `===` over `==` in two places.
PR-URL: #11511
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 09c9105 commit 75af859
1 file changed
Lines changed: 2 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,7 +1,3 @@ | |||
| 1 | - // http://wiki.commonjs.org/wiki/Unit_Testing/1.0 | ||
| 2 | - // | ||
| 3 | - // THIS IS NOT TESTED NOR LIKELY TO WORK OUTSIDE V8! | ||
| 4 | - // | ||
| 5 | 1 | // Originally from narwhal.js (http://narwhaljs.org) | |
| 6 | 2 | // Copyright (c) 2009 Thomas Robinson <280north.com> | |
| 7 | 3 | // | |
@@ -213,7 +209,7 @@ function _deepEqual(actual, expected, strict, memos) { | |||
| 213 | 209 | } | |
| 214 | 210 | ||
| 215 | 211 | function isArguments(object) { | |
| 216 | - return Object.prototype.toString.call(object) == '[object Arguments]'; | ||
| 212 | + return Object.prototype.toString.call(object) === '[object Arguments]'; | ||
| 217 | 213 | } | |
| 218 | 214 | ||
| 219 | 215 | function objEquiv(a, b, strict, actualVisitedObjects) { | |
@@ -298,7 +294,7 @@ function expectedException(actual, expected) { | |||
| 298 | 294 | return false; | |
| 299 | 295 | } | |
| 300 | 296 | ||
| 301 | - if (Object.prototype.toString.call(expected) == '[object RegExp]') { | ||
| 297 | + if (Object.prototype.toString.call(expected) === '[object RegExp]') { | ||
| 302 | 298 | return expected.test(actual); | |
| 303 | 299 | } | |
| 304 | 300 | ||
0 commit comments