FazBrowse GitHub Viewer | Trending | | Home

Tools: [Download Repo ZIP] [Original HTTPS Page]

test: add ALPNProtocols option to clientOptions · nodejs/node@7685297 · GitHub

Commit 7685297

authored and

committed

test: add ALPNProtocols option to clientOptions

Without this, the session is destroyed with the following error ``` Error [ERR_HTTP2_ERROR]: Protocol error at Http2Session.onSessionInternalError (internal/http2/core.js:756:26) Emitted 'error' event on ClientHttp2Session instance at: at emitClose (internal/http2/core.js:1010:10) at internal/http2/core.js:1048:7 at finish (internal/streams/writable.js:731:5) at processTicksAndRejections (internal/process/task_queues.js:80:21) { code: 'ERR_HTTP2_ERROR', errno: -505 } ``` The test then calls `session.close()` which tries to write to a destroyed socket. As a result, an unhandled `ECONNRESET` error is emitted in the v12 release line. PR-URL: #35482 Refs: #34859 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 85dc84d commit 7685297Copy full SHA for 7685297

1 file changed

test/parallel
- test-http2-connect.js

‎test/parallel/test-http2-connect.js‎

-Original file line number
+Diff line change
@@ @@ -95,6 +95,7 @@ const { connect: tlsConnect } = require('tls'); @@
     };
     const clientOptions = {
 +      ALPNProtocols: ['h2'],
       port,
       rejectUnauthorized: false
     };

Comments

(0)

Back | FazBrowse Home | New Git URL