assert,util: correct comparison when both contain same reference · nodejs/node@76fd0ea · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 76fd0ea

Browse filesBrowse the repository at this point in the historyBrowse files

authored and

marco-ippolito

committed

assert,util: correct comparison when both contain same reference

Co-authored-by: Chris Harvey <1362083+chharvey@users.noreply.github.com> PR-URL: #53431 Refs: #53423 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent cac300e commit 76fd0ea
Copy full SHA for 76fd0ea

2 files changed

+7-2Lines changed: 7 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/util
  • comparisons.js
• test/parallel
  • test-assert-deep.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/util/comparisons.js‎

Copy file name to clipboardExpand all lines: lib/internal/util/comparisons.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -502,8 +502,9 @@ function setEquiv(a, b, strict, memo) {
502	502	for (const val of b) {
503	503	// Primitive values have already been handled above.
504	504	if (typeof val === 'object' && val !== null) {
505		- if (!setHasEqualElement(set, val, strict, memo))
	505	+ if (!a.has(val) && !setHasEqualElement(set, val, strict, memo)) {
506	506	return false;
	507	+ }
507	508	} else if (!strict &&
508	509	!a.has(val) &&
509	510	!setHasEqualElement(set, val, strict, memo)) {

Collapse file

‎test/parallel/test-assert-deep.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-assert-deep.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -375,7 +375,11 @@ assertOnlyDeepEqual(
375	375	new Map([[undefined, null], ['+000', 2n]]),
376	376	new Map([[null, undefined], [false, '2']]),
377	377	);
378		-
	378	+ const xarray = ['x'];
	379	+ assertDeepAndStrictEqual(
	380	+ new Set([xarray, ['y']]),
	381	+ new Set([xarray, ['y']])
	382	+ );
379	383	assertOnlyDeepEqual(
380	384	new Set([null, '', 1n, 5, 2n, false]),
381	385	new Set([undefined, 0, 5n, true, '2', '-000'])

0 commit comments

Comments

0 (0)