build: remove V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE defs · nodejs/node@77189c1 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 77189c1

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

aduh95

committed

build: remove V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE defs

It has been renamed to V8_COMPRESS_POINTERS_IN_MULTIPLE_CAGES in https://chromium-review.googlesource.com/c/v8/v8/+/5439559 PR-URL: #60296 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

1 parent 4390889 commit 77189c1
Copy full SHA for 77189c1

2 files changed

-6Lines changed: 0 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• common.gypi
• tools/v8_gypfiles
  • features.gypi

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -452,9 +452,6 @@
452	452	['v8_enable_pointer_compression_shared_cage == 1', {
453	453	'defines': ['V8_COMPRESS_POINTERS_IN_SHARED_CAGE'],
454	454	}],
455		- ['v8_enable_pointer_compression == 1 and v8_enable_pointer_compression_shared_cage != 1', {
456		- 'defines': ['V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE'],
457		- }],
458	455	['v8_enable_pointer_compression == 1 or v8_enable_31bit_smis_on_64bit_arch == 1', {
459	456	'defines': ['V8_31BIT_SMIS_ON_64BIT_ARCH'],
460	457	}],

Collapse file

‎tools/v8_gypfiles/features.gypi‎

Copy file name to clipboardExpand all lines: tools/v8_gypfiles/features.gypi

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -373,9 +373,6 @@
373	373	['v8_enable_pointer_compression_shared_cage==1', {
374	374	'defines': ['V8_COMPRESS_POINTERS_IN_SHARED_CAGE'],
375	375	}],
376		- ['v8_enable_pointer_compression==1 and v8_enable_pointer_compression_shared_cage==0', {
377		- 'defines': ['V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE'],
378		- }],
379	376	['v8_enable_pointer_compression==1 or v8_enable_31bit_smis_on_64bit_arch==1', {
380	377	'defines': ['V8_31BIT_SMIS_ON_64BIT_ARCH',],
381	378	}],

0 commit comments

Comments

0 (0)