tools: be intentional about masking possible error in start-ci.sh · nodejs/node@7815fbd · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 592
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 7815fbd

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

danielleadams

committed

tools: be intentional about masking possible error in start-ci.sh

Revise start-ci.sh to conform with shellcheck 0.8.0 default checks. Refs: https://www.shellcheck.net/wiki/SC2312 PR-URL: #41284 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent 9eb8233 commit 7815fbd
Copy full SHA for 7815fbd

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tools/actions
  • start-ci.sh

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tools/actions/start-ci.sh‎

Copy file name to clipboardExpand all lines: tools/actions/start-ci.sh

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -17,7 +17,7 @@ for pr in "$@"; do
17	17	# Do we need to reset?
18	18	gh pr edit "$pr" --add-label "$REQUEST_CI_FAILED_LABEL"
19	19
20		- jq -n --arg content "<details><summary>Couldn't start CI</summary><pre>$(cat output)</pre></details>" > output.json
	20	+ jq -n --arg content "<details><summary>Couldn't start CI</summary><pre>$(cat output || true)</pre></details>" > output.json
21	21
22	22	gh pr comment "$pr" --body-file output.json
23	23

0 commit comments

Comments

0 (0)