Commit 788d736
doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break.
PR-URL: #11163
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>1 parent 533d2bf commit 788d736
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -119,7 +119,7 @@ followed to determine which aspects of the Node.js API are considered | |||
| 119 | 119 | ||
| 120 | 120 | Exception to each of these points can be made if use or behavior of a given | |
| 121 | 121 | internal API can be demonstrated to be sufficiently relied upon by the Node.js | |
| 122 | - ecosystem such that any changes would cause too much breakage. The threshhold | ||
| 122 | + ecosystem such that any changes would cause too much breakage. The threshold | ||
| 123 | 123 | for what qualifies as "too much breakage" is to be decided on a case-by-case | |
| 124 | 124 | basis by the CTC. | |
| 125 | 125 | ||
@@ -158,7 +158,8 @@ sufficient review by collaborators and approval of at least two CTC members. | |||
| 158 | 158 | ||
| 159 | 159 | Examples of breaking changes include, but are not necessarily limited to, | |
| 160 | 160 | removal or redefinition of existing API arguments, changing return values | |
| 161 | - (except when return values do not currently exist), removing or modifying existing properties on an options argument, adding or removing errors, | ||
| 161 | + (except when return values do not currently exist), removing or modifying | ||
| 162 | + existing properties on an options argument, adding or removing errors, | ||
| 162 | 163 | changing error messages in any way, altering expected timing of an event (e.g. | |
| 163 | 164 | moving from sync to async responses or vice versa), and changing the | |
| 164 | 165 | non-internal side effects of using a particular API. | |
0 commit comments