Commit 78dcf0d
src: fix handle leak in UDPWrap::Instantiate()
Create a handle scope before performing a check that creates a handle,
otherwise the handle is leaked into the handle scope of the caller.
PR-URL: #7711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>1 parent dc766e6 commit 78dcf0d
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -436,9 +436,9 @@ void UDPWrap::OnRecv(uv_udp_t* handle, | |||
| 436 | 436 | ||
| 437 | 437 | ||
| 438 | 438 | Local<Object> UDPWrap::Instantiate(Environment* env, AsyncWrap* parent) { | |
| 439 | + EscapableHandleScope scope(env->isolate()); | ||
| 439 | 440 | // If this assert fires then Initialize hasn't been called yet. | |
| 440 | 441 | CHECK_EQ(env->udp_constructor_function().IsEmpty(), false); | |
| 441 | - EscapableHandleScope scope(env->isolate()); | ||
| 442 | 442 | Local<Value> ptr = External::New(env->isolate(), parent); | |
| 443 | 443 | return scope.Escape(env->udp_constructor_function() | |
| 444 | 444 | ->NewInstance(env->context(), 1, &ptr).ToLocalChecked()); | |
0 commit comments