Commit 78f8180
events: no stopPropagation call in cancelBubble
PR-URL: #50405
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent ec17fd7 commit 78f8180
2 files changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -306,7 +306,7 @@ class Event { | |||
| 306 | 306 | if (!isEvent(this)) | |
| 307 | 307 | throw new ERR_INVALID_THIS('Event'); | |
| 308 | 308 | if (value) { | |
| 309 | - this.stopPropagation(); | ||
| 309 | + this.#propagationStopped = true; | ||
| 310 | 310 | } | |
| 311 | 311 | } | |
| 312 | 312 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -738,3 +738,10 @@ let asyncTest = Promise.resolve(); | |||
| 738 | 738 | controller.abort(); | |
| 739 | 739 | et.dispatchEvent(new Event('foo')); | |
| 740 | 740 | } | |
| 741 | + | ||
| 742 | + { | ||
| 743 | + const event = new Event('foo'); | ||
| 744 | + strictEqual(event.cancelBubble, false); | ||
| 745 | + event.cancelBubble = true; | ||
| 746 | + strictEqual(event.cancelBubble, true); | ||
| 747 | + } | ||
0 commit comments