test: improve test-worker-message-port-message-before-close · nodejs/node@79a277e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 79a277e

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

BridgeAR

committed

test: improve test-worker-message-port-message-before-close

Replace a wrong comment with a correct assertion and await all async operations inside the async function. PR-URL: #29483 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent 53f2371 commit 79a277e
Copy full SHA for 79a277e

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-worker-message-port-message-before-close.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-worker-message-port-message-before-close.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-worker-message-port-message-before-close.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -28,11 +28,11 @@ async function test() {
28	28	for (let i = 0; i < 10000; i++) {
29	29	const { port1, port2 } = new MessageChannel();
30	30	worker.postMessage({ port: port2 }, [ port2 ]);
31		- await once(port1, 'message'); // 'complexObject'
	31	+ assert.deepStrictEqual(await once(port1, 'message'), ['firstMessage']);
32	32	assert.deepStrictEqual(await once(port1, 'message'), ['lastMessage']);
33	33	}
34	34
35		- worker.terminate();
	35	+ await worker.terminate();
36	36	}
37	37
38	38	test().then(common.mustCall());

0 commit comments

Comments

0 (0)