Commit 79bd39c
build: add v8 requirement to test-v8* in Makefile
The test targets expect that V8 is built in deps/v8/out
Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent b956635 commit 79bd39c
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -227,22 +227,22 @@ test-timers: | |||
| 227 | 227 | test-timers-clean: | |
| 228 | 228 | $(MAKE) --directory=tools clean | |
| 229 | 229 | ||
| 230 | - test-v8: | ||
| 230 | + test-v8: v8 | ||
| 231 | 231 | # note: performs full test unless QUICKCHECK is specified | |
| 232 | 232 | deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \ | |
| 233 | 233 | --mode=$(BUILDTYPE_LOWER) $(V8_TEST_NO_I18N) $(QUICKCHECK_ARG) \ | |
| 234 | 234 | --no-presubmit \ | |
| 235 | 235 | --shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \ | |
| 236 | 236 | $(TAP_V8) | |
| 237 | 237 | ||
| 238 | - test-v8-intl: | ||
| 238 | + test-v8-intl: v8 | ||
| 239 | 239 | # note: performs full test unless QUICKCHECK is specified | |
| 240 | 240 | deps/v8/tools/run-tests.py --arch=$(V8_ARCH) \ | |
| 241 | 241 | --mode=$(BUILDTYPE_LOWER) --no-presubmit $(QUICKCHECK_ARG) \ | |
| 242 | 242 | --shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) intl \ | |
| 243 | 243 | $(TAP_V8_INTL) | |
| 244 | 244 | ||
| 245 | - test-v8-benchmarks: | ||
| 245 | + test-v8-benchmarks: v8 | ||
| 246 | 246 | deps/v8/tools/run-tests.py --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \ | |
| 247 | 247 | --download-data $(QUICKCHECK_ARG) --no-presubmit \ | |
| 248 | 248 | --shell-dir=deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) benchmarks \ | |
0 commit comments