Commit 79c0497
doc: make the NODE_VERSION_IS_RELEASE revert clear
PR-URL: #49114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>1 parent 981aa78 commit 79c0497
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -813,7 +813,9 @@ $ git commit --amend | |||
| 813 | 813 | </details> | |
| 814 | 814 | ||
| 815 | 815 | Even if there are no conflicts, ensure that you revert all the changes that were | |
| 816 | - made to `src/node_version.h`. | ||
| 816 | + made to `src/node_version.h`. `NODE_VERSION_IS_RELEASE` must be `0`. | ||
| 817 | + | ||
| 818 | + <sup>Edit `src/node_version.h`, revert `NODE_VERSION_IS_RELEASE` back to `0`, and `git commit --amend`</sup> | ||
| 817 | 819 | ||
| 818 | 820 | If there are conflicts in `doc` due to updated `REPLACEME` | |
| 819 | 821 | placeholders (that happens when a change previously landed on another release | |
0 commit comments